Skip to content

NGFW-15826: fix InheritableThreadLocal race in MarshallingModeContext #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhrohit23 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NGFW-15826: fix InheritableThreadLocal race in MarshallingModeContext #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified jabsorb-1.2.5.jar
View file
Open in desktop
Binary file not shown.
Binary file modified json.jar
View file
Open in desktop
Binary file not shown.
7 changes: 5 additions & 2 deletions src/org/jabsorb/serializer/MarshallingModeContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package org.jabsorb.serializer;

import java.util.Deque;
import java.util.Stack;
import java.util.ArrayDeque;
import java.util.Deque;

/**
* Context that holds the marshalling mode for a given thread.
Expand All @@ -16,6 +15,10 @@ public class MarshallingModeContext {
protected Deque<MarshallingMode> initialValue() {
return new ArrayDeque<>();
}
@Override
protected Deque<MarshallingMode> childValue(Deque<MarshallingMode> parentValue) {
return new ArrayDeque<>(parentValue);
}
};

/**
Expand Down
9 changes: 9 additions & 0 deletions webapps/jsonrpc/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
CHANGES log

2026-06-15 jabsorb 1.2.5 fix

* Fix InheritableThreadLocal race in MarshallingModeContext
* Override childValue() to return a defensive copy of the parent's ArrayDeque
* instead of sharing the same mutable reference. On JDK21, aggressive parallel
* thread creation during UVM startup caused concurrent push/pop corruption on
* the shared stack, silently failing SettingsManager.save() and leaving settings
* files (admin.js, system.js) missing from disk.

2025-08-05 jabsorb 1.2.5 release

* Support for Two Marshalling Modes
Expand Down