NGFW-15826: fix InheritableThreadLocal race in MarshallingModeContext#8
Open
singhrohit23 wants to merge 1 commit into
Open
NGFW-15826: fix InheritableThreadLocal race in MarshallingModeContext#8singhrohit23 wants to merge 1 commit into
singhrohit23 wants to merge 1 commit into
Conversation
Override childValue() to return a defensive copy of the parent's ArrayDeque. Child threads sharing the parent's mutable stack causes concurrent push/pop corruption on JDK21 during UVM startup.
singhrohit23
requested review from
AristaKB and
mayur-dhande
and removed request for
mayur-dhande
mayur-dhande
approved these changes
Jun 15, 2026
mayur-dhande
left a comment
mayur-dhande
left a comment
Collaborator
There was a problem hiding this comment.
I dont remember we commit jar file in this repo.
We have this doc https://awakesecurity.atlassian.net/wiki/spaces/ngfw/pages/2471755796/Jabsorb+Library+Upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override childValue() to return a defensive copy of the parent's ArrayDeque. Child threads sharing the parent's mutable stack causes concurrent push/pop corruption on JDK21 during UVM startup.