Remove obsolete retrying patch from tests#274
Merged
TheJulianJES merged 1 commit intoMay 31, 2026
Conversation
`Device._initialize` is no longer wrapped with a retry decorator in zigpy 1.5.0, so `Device._initialize.__wrapped__` raises AttributeError at collection time. The `@mock.patch(..., new=...__wrapped__)` only existed to strip those retries, which no longer exist, so drop it from the three join/announce tests (and the now-unused zigpy.device import).
This was referenced May 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device._initializeis no longer wrapped with a retry decorator in zigpy 1.5.0, soDevice._initialize.__wrapped__raises AttributeError at collection time. The@mock.patch(..., new=...__wrapped__)only existed to strip those retries, which no longer exist, so drop it from the three join/announce tests (and the now-unused zigpy.device import).Requires #273 for tests to pass.