#525: Github_graph.rb excluded from coverage#533
Merged
yegor256 merged 2 commits intoJun 8, 2026
Conversation
…ph tests The add_filter excluded github_graph.rb from coverage despite having tests. Removed the filter and added 16 new tests for the real Fbe::Graph class methods by stubbing the query method with mock objects. This achieves 89% coverage for the file, above the 80% minimum. - Added tests for: total_commits, total_issues_and_pulls, resolved_conversations, issue_type_event, total_commits_pushed, total_issues_created, total_releases_published, pull_requests_with_reviews, pull_request_reviews
VasilevNStas
changed the title
Contributor
Author
|
@yegor256 please review |
|
@VasilevNStas Thanks for the contribution! You've earned +20 points for this: +24 as a basis, +16 for hits-of-code (315 * 0.075 capped at 16), -4 for exceeding 133 hits-of-code, and -16 for excessive review comments. Please, keep them coming. Your running score is +824; don't forget to check your Zerocracy account too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_filter lib/fbe/github_graph.rbfrom SimpleCov config intest__helper.rbFbe::Graphclass by stubbing thequerymethodgithub_graph.rb, above the 80% minimum