Codex/fix findings kanban validation#23
Merged
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens and refactors several worker security components and Temporal utilities, primarily to improve correctness around URL/version handling, workflow sandbox compatibility, and CLI arg construction (with accompanying unit tests).
Changes:
- Guard workflow diagnostics logging to avoid
processaccess errors in the Temporal workflow sandbox, and add a regression test. - Centralize internal MCP URL construction to avoid double-prefixing
/api/v1, with unit test coverage. - Refactor/adjust security tool runners (notably nuclei/httpx/katana) to improve argument building and runner output parsing strictness, and add new component tests (OSV/NVD).
Reviewed changes
Copilot reviewed 99 out of 99 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| worker/src/temporal/workflow-diagnostics.ts | Adds a sandbox-safe process guard for workflow diagnostics logging. |
| worker/src/temporal/tests/workflow-diagnostics.test.ts | Verifies diagnostics helper doesn’t throw when process is unavailable. |
| worker/src/temporal/activities/mcp.activity.ts | Introduces URL builders to normalize versioned API base URLs for internal MCP calls. |
| worker/src/temporal/activities/tests/mcp.activity.test.ts | Adds coverage ensuring /api/v1 is not double-prefixed. |
| worker/src/components/security/nuclei.ts | Switches nuclei runner strategy (upstream image + shell wrapper) and introduces a reusable docker-command builder. |
| worker/src/components/security/katana.ts | Extracts scope mapping and argument construction into testable helpers; tightens runner output schema. |
| worker/src/components/security/httpx.ts | Extracts httpx argument construction into a helper and tightens runner output schema. |
| worker/src/components/security/tests/osv.test.ts | Adds unit coverage for OSV parsing/severity inference/hydration and component execution behavior. |
| worker/src/components/security/tests/nvd.test.ts | Adds unit coverage for NVD URL building and component execution behavior (incl. timeout handling). |
Comments suppressed due to low confidence (1)
worker/src/components/security/nuclei.ts:151
updateTemplatesnow defaults totrue, but the UI description still says "slower, usually not needed". With the upstreamprojectdiscovery/nuclei:latestimage this option is likely needed to ensure templates exist; the current wording conflicts with the new default and can mislead users about recommended usage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (runnerParams.preferHttps) { | ||
| httpxArgs.push('-prefer-https'); | ||
| } | ||
| const httpxArgs = buildHttpxArgs(runnerParams); |
Comment on lines
353
to
356
| const args: string[] = [ | ||
| '-duc', // Disable update check (templates pre-installed in image) | ||
| '-jsonl', // JSONL output format (nuclei v3.6.0+) | ||
| '-stream', // Stream mode: prevents buffering, required for PTY compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.