Skip to content

Entity hub: Use set for assignees #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iLLiCiTiT merged 1 commit into from
May 26, 2026
Merged

Entity hub: Use set for assignees #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ayon_api/entity_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ class ProjectStatusDict(TypedDict):
scope: NotRequired[Optional[StatusEntityType]]


class Assignees(set):
"""Helper class for task assignees.

Assignees used to be a list and 'append' is being used a lot.
"""
def append(self, item: str) -> None:
self.add(item)


class _CustomNone:
def __init__(self, name: Optional[str] = None) -> None:
self._name = name or "CustomNone"
Expand Down Expand Up @@ -3430,9 +3439,9 @@ def __init__(
entity_hub=entity_hub,
)
if assignees is None:
assignees = []
assignees = Assignees()
else:
assignees = list(assignees)
assignees = Assignees(assignees)

self._task_type = task_type
self._assignees = assignees
Expand Down Expand Up @@ -3463,11 +3472,11 @@ def set_task_type(self, task_type: str) -> None:

task_type = property(get_task_type, set_task_type)

def get_assignees(self) -> list[str]:
def get_assignees(self) -> Assignees[str]:
"""Task assignees.

Returns:
list[str]: Task assignees.
Assignees[str]: Task assignees.

"""
return self._assignees
Expand All @@ -3479,7 +3488,7 @@ def set_assignees(self, assignees: Iterable[str]) -> None:
assignees (Iterable[str]): assignees.

"""
self._assignees = list(assignees)
self._assignees = Assignees(assignees)

assignees = property(get_assignees, set_assignees)

Expand All @@ -3497,7 +3506,7 @@ def changes(self) -> dict[str, Any]:
changes["taskType"] = self._task_type

if self._orig_assignees != self._assignees:
changes["assignees"] = self._assignees
changes["assignees"] = list(self._assignees)

return changes

Expand Down Expand Up @@ -3549,7 +3558,7 @@ def to_create_body_data(self) -> dict[str, Any]:
output["tags"] = self.tags

if self.assignees:
output["assignees"] = self.assignees
output["assignees"] = list(self.assignees)

if self._data is not UNKNOWN_VALUE:
output["data"] = self._data.get_new_entity_value()
Expand Down
Loading