Fixed exceptions from Annoy and nearest_neighbors#20
Open
WilliamGustafson wants to merge 1 commit into
Open
Conversation
* In Process.query and Process.index self.nearest_neighbors does not expect a sparse matrix, now the vectors are converted to a dense numpy matrix * The metric name 'cosine' is not used in Annoy, so the default metric in char_ngram_process was changed to 'angular' (the closest analogue) * sklearn's pairwise_distances function doesn't have an 'angular' metric so 'cosine' is used in process.ratio in place of 'angular'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for Issues #19 and #18.