Skip to content

build: Update @workos-inc/node to v10.4.0#48

Open
nicknisi wants to merge 1 commit into
mainfrom
devin/1781791493-update-workos-node
Open

build: Update @workos-inc/node to v10.4.0#48
nicknisi wants to merge 1 commit into
mainfrom
devin/1781791493-update-workos-node

Conversation

@nicknisi

Copy link
Copy Markdown
Member

Summary

Bumps the @workos-inc/node devDependency from ^9.2.0^10.4.0.

The v10 User type adds a required name: string | null field. Test mock users are updated to include it.

peerDependencies already covers ^10.0.0 — no change needed there.

Link to Devin session: https://app.devin.ai/sessions/a7f20efe6f624b8797ea589d65ed0f9a
Requested by: @nicknisi

- Bump devDependency from ^9.2.0 to ^10.4.0
- Add name property to mock User objects in tests (new
  required field in v10 User type)
- Add pnpm-workspace.yaml with minimumReleaseAgeExclude
  for the newly published version

Co-Authored-By: nick.nisi@workos.com <nick.nisi@workos.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor
Original prompt from Nick.nisi

Update authkit-session to use the latest @workos-inc/node

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@nicknisi nicknisi requested a review from gjtorikian June 18, 2026 14:05
@nicknisi nicknisi changed the title Update @workos-inc/node to v10.4.0 fix: Update @workos-inc/node to v10.4.0 Jun 18, 2026
@devin-ai-integration devin-ai-integration Bot changed the title fix: Update @workos-inc/node to v10.4.0 build: Update @workos-inc/node to v10.4.0 Jun 18, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 potential issues.

Open in Devin Review

@greptile-apps

greptile-apps Bot commented Jun 18, 2026

Copy link
Copy Markdown

Greptile Summary

  • Bumps @workos-inc/node from v9.2.0 to v10.4.0.
  • Updates the pnpm lockfile for the new SDK version.
  • Adds the new required name field to WorkOS user fixtures in tests.
  • Adds a pnpm minimum-release-age exclusion for the updated SDK package.

Confidence Score: 4/5

The dependency update is mostly narrow, but the published runtime support now conflicts with the upgraded SDK requirement and should be resolved before merging.

The changed files are limited to dependency metadata, lockfile/workspace config, and test fixtures, and the main risk is concentrated in the Node engine mismatch.

package.json and any CI configuration that still installs or tests on Node 20.

T-Rex T-Rex Logs

What T-Rex did

  • Reproduced the Node engine compatibility issue: Node 20 fails to satisfy WorkOS SDK 10.4.0 due to engines.node requirements, observed as an EBADENGINE error during a minimal consumer install.
  • Compared before-and-after dependency upgrade artifacts to verify the upgrade from devDependency ^9.2.0 to ^10.4.0, while the peer range and tests remained aligned.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (1)

  1. package.json, line 58 (link)

    P1 Align Node support

    This package still advertises Node >=20.0.0, but the updated @workos-inc/node@10.4.0 dependency requires Node >=22.11.0. A consumer running Node 20 can satisfy this package's engine and peer range while resolving WorkOS SDK v10, leaving them on an unsupported runtime combination that can fail during install, build, or import. The CI matrix also still installs and tests on Node 20, so please either raise this package's engine and CI matrix to the SDK's minimum Node version, or use a WorkOS SDK version compatible with Node 20.

    Artifacts

    Repro: repository package engine and peer range output

    • Keeps the command output available without making the summary code-heavy.

    Repro: WorkOS SDK 10.4.0 npm engine metadata output

    • Keeps the command output available without making the summary code-heavy.

    Repro: Node 20 minimal consumer install script

    • Contains supporting evidence from the run (text/x-shellscript; charset=utf-8).

    Repro: Node 20 consumer install EBADENGINE output

    • Keeps the command output available without making the summary code-heavy.

    View artifacts

    T-Rex Ran code and verified through T-Rex

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: package.json
    Line: 58
    
    Comment:
    **Align Node support**
    
    This package still advertises Node `>=20.0.0`, but the updated `@workos-inc/node@10.4.0` dependency requires Node `>=22.11.0`. A consumer running Node 20 can satisfy this package's engine and peer range while resolving WorkOS SDK v10, leaving them on an unsupported runtime combination that can fail during install, build, or import. The CI matrix also still installs and tests on Node 20, so please either raise this package's engine and CI matrix to the SDK's minimum Node version, or use a WorkOS SDK version compatible with Node 20.
    
    How can I resolve this? If you propose a fix, please make it concise.

    Fix in Devin Fix in Claude Code

Fix All in Devin Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
package.json:58
**Align Node support**

This package still advertises Node `>=20.0.0`, but the updated `@workos-inc/node@10.4.0` dependency requires Node `>=22.11.0`. A consumer running Node 20 can satisfy this package's engine and peer range while resolving WorkOS SDK v10, leaving them on an unsupported runtime combination that can fail during install, build, or import. The CI matrix also still installs and tests on Node 20, so please either raise this package's engine and CI matrix to the SDK's minimum Node version, or use a WorkOS SDK version compatible with Node 20.

Reviews (1): Last reviewed commit: "Update @workos-inc/node to v10.4.0" | Re-trigger Greptile

@devin-ai-integration

Copy link
Copy Markdown
Contributor

This is not a concrete issue. @workos-inc/node is a peerDependency (^8.0.0 || ^9.0.0 || ^10.0.0) — consumers bring their own version. A consumer on Node 20 can use @workos-inc/node@8.x or @9.x (both support Node 20) and satisfy the peer range. The SDK's own engines field warns Node 20 consumers away from resolving v10.

The devDependency at v10 is only used during development/testing of this package and doesn't affect consumers. Raising engines.node to >=22.11.0 would be a breaking change for consumers who use authkit-session + @workos-inc/node@8.x/@9.x on Node 20 — which is a supported combination.

CI testing on Node 20 is intentional and passes because authkit-session itself has no Node 22+ runtime requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant