Skip to content

fix memory report and add path filter#10538

Open
michael-membrowse wants to merge 1 commit into
wolfSSL:masterfrom
michael-membrowse:membrowse-report-path-filter
Open

fix memory report and add path filter#10538
michael-membrowse wants to merge 1 commit into
wolfSSL:masterfrom
michael-membrowse:membrowse-report-path-filter

Conversation

@michael-membrowse
Copy link
Copy Markdown
Contributor

Description

Following a conversation with @dgarske:

Fix the MemBrowse report flow to support push to master and PR changes.

The following optimizations were made:

  1. The workflow is optimized to skip build and report generation in case of non operational changes.
  2. The repo checkout is optimized to checkout just the last 2 commits instead of the whole history.

Also, added support for a new MemBrowse feature that includes library attribution.
Now, you can see how libraries contribute to the footprint.
image

In case this will still be slow (which it shouldn't: the workflow takes around 90 seconds):
I would suggest the following steps:

  1. Remove the trigger from the PRs and just keep the push to master trigger.
  2. Reduce the targets amount that are being tracked.

Testing

Tested on forked repo

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970a82cb35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/membrowse-comment.yml
@dgarske
Copy link
Copy Markdown
Member

dgarske commented May 27, 2026

Okay to test. Contributor agreement on file.

@dgarske
Copy link
Copy Markdown
Member

dgarske commented May 27, 2026

Jenkins retest this please.

@michael-membrowse michael-membrowse force-pushed the membrowse-report-path-filter branch from 970a82c to bddf76d Compare May 27, 2026 18:18
@michael-membrowse
Copy link
Copy Markdown
Contributor Author

Had to fix the concurrency condition. Please rerun the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants