fix memory report and add path filter#10538
Open
michael-membrowse wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 970a82cb35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
Okay to test. Contributor agreement on file. |
Member
|
Jenkins retest this please. |
970a82c to
bddf76d
Compare
Contributor
Author
|
Had to fix the concurrency condition. Please rerun the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following a conversation with @dgarske:
Fix the MemBrowse report flow to support push to master and PR changes.
The following optimizations were made:
Also, added support for a new MemBrowse feature that includes library attribution.

Now, you can see how libraries contribute to the footprint.
In case this will still be slow (which it shouldn't: the workflow takes around 90 seconds):
I would suggest the following steps:
Testing
Tested on forked repo
Checklist