F-4985 Integer Overflow#235
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bounds checking in wolfCLU_HttpServerRecv() to prevent integer overflow when comparing totalLen against headerSz + contentLen, and clamps contentLen to the available buffer space. Callers are expected to re-validate the received body length against the advertised Content-Length.
Changes:
- Clamp
contentLenso it cannot exceed remaining buffer capacity (bufferSz - 1 - headerSz). - Reformulate the "full body received" check as
totalLen - headerSz >= contentLento avoid potential overflow inheaderSz + contentLen. - Update doc comment to describe the clamping behavior and caller responsibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #235
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
stenslae
force-pushed
the
4985-integer-overflow
branch
from
2bac6b6 to
ca94898
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #235
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
cconlon
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added bounds checking in wolfCLU_HttpServerRecv().