Fix heap over read#234
Open
aidankeefe2022 wants to merge 1 commit into
Open
Conversation
aidankeefe2022
force-pushed
the
fix-heap-over-read
branch
from
bf2788f to
947fe24
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #234
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes malformed X.509 subject parsing in wolfCLU_ParseX509NameString to avoid reading past the end of a token when a subject component is missing =.
Changes:
- Adds an explicit delimiter check after
strcspn()so tokens without=fail safely. - Preserves existing error handling by freeing the partially built name and returning
NULL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| word = strtok_r(NULL, deli, &end)) { | ||
| tagSz = (int)strcspn(word, "="); | ||
| if (tagSz <= 0) { | ||
| if (tagSz <= 0 || word[tagSz] != '=') { |
Member
|
@aidankeefe2022, I agree with copilot above. Let's see if we can easily add a unit test to cover this edge case. |
…t in a non-success program exit and added more clear error reporting
aidankeefe2022
force-pushed
the
fix-heap-over-read
branch
from
947fe24 to
bec36e7
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #234
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x509 name can look like this /CN=name/C=company the parsing function did not account for strings that had missing = at the end of the string /CN=name/Ccompany. This caused an issue where the parsing logic would attempt to access one passed the last byte of the string. There is now logic to explicitly catch when this is the case.