Skip to content

fix: accessibility heading semantics [WPB-14776]#4972

Merged
Garzas merged 1 commit into
developfrom
fix/a11y-heading-semantics
Jun 16, 2026
Merged

fix: accessibility heading semantics [WPB-14776]#4972
Garzas merged 1 commit into
developfrom
fix/a11y-heading-semantics

Conversation

@Garzas

@Garzas Garzas commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-14776


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Marked visual screen titles and section labels as accessibility headings across login/onboarding, conversations, archive, settings, user profile, conversation details, and call-related screens.
  • Added heading semantics to shared UI components such as section headers and empty-state titles so reused views expose the correct structure to TalkBack.
  • Added Compose instrumentation coverage to verify key heading components expose SemanticsProperties.Heading.

@Garzas Garzas requested review from saleniuk and sbakhtiarov June 16, 2026 12:10
@Garzas Garzas self-assigned this Jun 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.77%. Comparing base (1f84f90) to head (dab52c4).

Files with missing lines Patch % Lines
...id/ui/newauthentication/login/NewLoginContainer.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4972      +/-   ##
===========================================
- Coverage    48.77%   48.77%   -0.01%     
===========================================
  Files          644      645       +1     
  Lines        23151    23152       +1     
  Branches      3546     3546              
===========================================
  Hits         11292    11292              
- Misses       10811    10812       +1     
  Partials      1048     1048              
Files with missing lines Coverage Δ
...ettings/devices/EndToEndIdentityCertificateItem.kt 0.00% <ø> (ø)
...id/ui/newauthentication/login/NewLoginContainer.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f84f90...dab52c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas added this pull request to the merge queue Jun 16, 2026
Merged via the queue into develop with commit 54be620 Jun 16, 2026
22 of 23 checks passed
@Garzas Garzas deleted the fix/a11y-heading-semantics branch June 16, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants