Skip to content

fix: expose bottom sheet actions as buttons [WPB-14784]#4964

Open
Garzas wants to merge 4 commits into
developfrom
fix/bottom-sheet-action-accessibility-role
Open

fix: expose bottom sheet actions as buttons [WPB-14784]#4964
Garzas wants to merge 4 commits into
developfrom
fix/bottom-sheet-action-accessibility-role

Conversation

@Garzas

@Garzas Garzas commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-14784


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Bottom sheet action rows, such as “Move to Archive”, were exposed as clickable views without a button role in accessibility semantics.

Causes (Optional)

The shared bottom sheet items use a custom Modifier.clickable wrapper around combinedClickable, but no role was passed to the underlying semantics.

Solutions

Added optional role support to the shared clickable modifier and set Role.Button for bottom sheet menu actions.

@Garzas Garzas self-assigned this Jun 15, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.76%. Comparing base (c3f09ef) to head (168c6cb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4964   +/-   ##
========================================
  Coverage    48.76%   48.76%           
========================================
  Files          644      644           
  Lines        23145    23145           
  Branches      3545     3545           
========================================
  Hits         11287    11287           
  Misses       10809    10809           
  Partials      1049     1049           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f09ef...168c6cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant