fix: expose bottom sheet actions as buttons [WPB-14784]#4964
Open
Garzas wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4964 +/- ##
========================================
Coverage 48.76% 48.76%
========================================
Files 644 644
Lines 23145 23145
Branches 3545 3545
========================================
Hits 11287 11287
Misses 10809 10809
Partials 1049 1049 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-14784
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Bottom sheet action rows, such as “Move to Archive”, were exposed as clickable views without a button role in accessibility semantics.
Causes (Optional)
The shared bottom sheet items use a custom
Modifier.clickablewrapper aroundcombinedClickable, but no role was passed to the underlying semantics.Solutions
Added optional role support to the shared clickable modifier and set
Role.Buttonfor bottom sheet menu actions.