Skip to content

feat(meeting): select participants [WPB-25049]#4962

Merged
saleniuk merged 21 commits into
developfrom
feat/create-meeting-add-participants
Jun 15, 2026
Merged

feat(meeting): select participants [WPB-25049]#4962
saleniuk merged 21 commits into
developfrom
feat/create-meeting-add-participants

Conversation

@saleniuk

@saleniuk saleniuk commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25049


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • new screen to select participants to be added to the meeting
  • text transformation to show selected participants names on input just like on designs with ellipsis and "+X more" suffix
  • changed the way ViewModel is created and shared between multiple screens of the same creation flow
  • new feature-specific navigator to allow navigating to destinations from another modules
  • updated search use cases from kalium
  • logic of verifying meeting title and enabling button

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open dev debug build (meetings only available there), open meetings tab, click "new", choose "meet now", enter title and choose participants.

Attachments (Optional)

Screen_recording_20260612_162147.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@github-actions

Copy link
Copy Markdown
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
32a101719684eb1677b4dd4c8733d1b0dd987bb3 394b90ff1ce22ff8ee38bccf679616c2a13644fb

Is this intentional?

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.22449% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.76%. Comparing base (cab9265) to head (2e514cc).

Files with missing lines Patch % Lines
.../feature/meetings/ui/create/NewMeetingViewModel.kt 0.00% 37 Missing ⚠️
...ings/ui/create/TextListTruncationTransformation.kt 0.00% 35 Missing ⚠️
.../com/wire/android/search/SearchViewModelFactory.kt 0.00% 8 Missing ⚠️
...in/com/wire/android/search/SearchViewModelGraph.kt 0.00% 2 Missing ⚠️
...ture/meetings/ui/MeetingsMetroViewModelBindings.kt 0.00% 2 Missing ⚠️
...ire/android/search/SearchMetroViewModelBindings.kt 0.00% 1 Missing ⚠️
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 75.00% 1 Missing ⚠️
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (11.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4962      +/-   ##
===========================================
- Coverage    48.92%   48.76%   -0.17%     
===========================================
  Files          643      644       +1     
  Lines        23068    23144      +76     
  Branches      3525     3545      +20     
===========================================
  Hits         11287    11287              
- Misses       10732    10808      +76     
  Partials      1049     1049              
Files with missing lines Coverage Δ
.../src/main/kotlin/com/wire/android/model/Contact.kt 100.00% <100.00%> (ø)
...m/wire/android/search/users/SearchUserViewModel.kt 97.26% <100.00%> (+0.11%) ⬆️
...n/kotlin/com/wire/android/model/SnackBarMessage.kt 75.00% <ø> (ø)
...ire/android/search/SearchMetroViewModelBindings.kt 0.00% <0.00%> (ø)
...kotlin/com/wire/android/util/DateAndTimeParsers.kt 72.72% <75.00%> (-1.56%) ⬇️
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% <0.00%> (ø)
...in/com/wire/android/search/SearchViewModelGraph.kt 0.00% <0.00%> (ø)
...ture/meetings/ui/MeetingsMetroViewModelBindings.kt 0.00% <0.00%> (ø)
.../com/wire/android/search/SearchViewModelFactory.kt 0.00% <0.00%> (ø)
...ings/ui/create/TextListTruncationTransformation.kt 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab9265...2e514cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
32a101719684eb1677b4dd4c8733d1b0dd987bb3 394b90ff1ce22ff8ee38bccf679616c2a13644fb

Is this intentional?

@github-actions

Copy link
Copy Markdown
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
32a101719684eb1677b4dd4c8733d1b0dd987bb3 394b90ff1ce22ff8ee38bccf679616c2a13644fb

Is this intentional?

@saleniuk saleniuk requested review from Garzas and yamilmedina June 15, 2026 09:37
Comment thread app/src/main/kotlin/com/wire/android/navigation/MainNavHost.kt
@saleniuk saleniuk requested a review from ohassine June 15, 2026 12:50
@sonarqubecloud

Copy link
Copy Markdown

@saleniuk saleniuk added this pull request to the merge queue Jun 15, 2026
Merged via the queue into develop with commit c5a049b Jun 15, 2026
21 checks passed
@saleniuk saleniuk deleted the feat/create-meeting-add-participants branch June 15, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants