Skip to content

feat(drive): In app video player (WPB-25407)#4961

Open
ohassine wants to merge 16 commits into
developfrom
in-app-video-player
Open

feat(drive): In app video player (WPB-25407)#4961
ohassine wants to merge 16 commits into
developfrom
in-app-video-player

Conversation

@ohassine

@ohassine ohassine commented Jun 12, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-25407


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

  • Implement in-app video player that will play drive videos instead of relying on different app using Intents.
    -The player is using ExoPlayer
screen-20260609-172940-1781022560157.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 11 commits May 13, 2026 19:46
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerNavArgs.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/imageviewer/CellImageViewerViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/res/values/strings.xml
#	kalium
@ohassine ohassine requested a review from a team as a code owner June 12, 2026 13:21
@ohassine ohassine requested review from Garzas, alexandreferris, emmaoke-w, typfel and yamilmedina and removed request for a team June 12, 2026 13:21
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.69231% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.75%. Comparing base (cab9265) to head (36d78d7).

Files with missing lines Patch % Lines
...ature/cells/ui/videoplayer/VideoPlayerViewModel.kt 0.00% 63 Missing ⚠️
...feature/cells/ui/videoplayer/VideoPlaybackState.kt 0.00% 7 Missing ⚠️
...id/feature/cells/ui/CellsMetroViewModelBindings.kt 0.00% 6 Missing ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 44.44% 3 Missing and 2 partials ⚠️
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (7.69%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4961      +/-   ##
===========================================
- Coverage    48.92%   48.75%   -0.18%     
===========================================
  Files          643      645       +2     
  Lines        23068    23152      +84     
  Branches      3525     3542      +17     
===========================================
  Hits         11287    11287              
- Misses       10732    10814      +82     
- Partials      1049     1051       +2     
Files with missing lines Coverage Δ
...tions/usecase/GetConversationsFromSearchUseCase.kt 78.84% <100.00%> (ø)
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
.../android/feature/cells/ui/CellsViewModelFactory.kt 0.00% <0.00%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 44.84% <44.44%> (-0.64%) ⬇️
...id/feature/cells/ui/CellsMetroViewModelBindings.kt 0.00% <0.00%> (ø)
...feature/cells/ui/videoplayer/VideoPlaybackState.kt 0.00% <0.00%> (ø)
...ature/cells/ui/videoplayer/VideoPlayerViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab9265...36d78d7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
32a101719684eb1677b4dd4c8733d1b0dd987bb3 3a39fb17538cef4c96eee5459cf9707924889a24

Is this intentional?

@ohassine ohassine requested review from sbakhtiarov and removed request for alexandreferris and typfel June 15, 2026 10:20
@ohassine ohassine requested review from saleniuk and removed request for emmaoke-w June 15, 2026 15:56
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant