chore: session methods do not require a mutable ref to keystore#58
Merged
coriolinus merged 1 commit intoJun 9, 2026
Merged
Conversation
As the `PreKeyStore` trait methods no longer require mutable self references, the `Session` methods also no longer require mutable keystore references.
istankovic
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the
PreKeyStoretrait methods no longer require mutable self references, theSessionmethods also no longer require mutable keystore references.Technically this is a breaking change but really it's just finishing the changes introduced by 3.0.0
PR Submission Checklist for internal contributors
SQPIT-764