add support for musicxml 4.0 in mx::core#169
Merged
Merged
Conversation
Generator architecture and language targets sections replaced with a brief overview pointing to gen/AGENTS.md and gen/DESIGN.md.
webern
changed the title
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.9% | 28494 / 36571 |
| Functions | 74.4% | 6354 / 8542 |
| Branches | 50.7% | 22636 / 44653 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 68.7% | 4734 / 6895 |
| Functions | 53.5% | 1507 / 2816 |
| Branches | 40.3% | 3851 / 9562 |
Core HTML report | API HTML report
Commit 4002b978f2e8ea03997771974c5cdf6cc3b29ac7.
|
Let me look into the XCode target. What I have in my fork is an updated script to build a XCFramework, but it might use the workspace as the input. |
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.9% | 28505 / 36590 |
| Functions | 74.4% | 6354 / 8542 |
| Branches | 50.7% | 22645 / 44673 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 68.7% | 4734 / 6895 |
| Functions | 53.5% | 1507 / 2816 |
| Branches | 40.3% | 3851 / 9562 |
Core HTML report | API HTML report
Commit b277cf72327de2e77aef0d909a7181ef7a596f4f.
## Problem The `Linux (Go + C targets)` CI job fails at the **Go corert suite** step ([run](https://github.com/webern/mx/actions/runs/27506189030/job/81297724980)): ``` cd gen/test/go && MX_REPO_ROOT=/workspace go test -count=1 -v ./corert/ go: go: could not create module cache: mkdir /go: permission denied make: *** [Makefile:355: test-go] Error 1 ``` The `DOCKER_RUN` recipe runs the `mx-sdk` container as the caller's `uid:gid` (`--user 1001:1001` on the runner). That UID has no `/etc/passwd` entry, so `HOME` defaults to `/`. Go then derives `GOPATH=/go` and `GOCACHE=/.cache/go-build`, neither of which the unprivileged user can create. The C++ jobs don't hit this because the Dockerfile already pins `CCACHE_DIR` to the writable `/workspace/build` volume; Go had no equivalent override. ## Fix Pin `GOPATH`, `GOCACHE`, and `GOMODCACHE` under the writable `/workspace/build` volume in the Dockerfile, exactly mirroring `CCACHE_DIR`. The Go module is vendored (`gen/test/go/vendor/`), so no network fetch is needed. ## Base Targets `musicxml-4.0` so that merging this folds the fix into PR #169.
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.9% | 28505 / 36590 |
| Functions | 74.4% | 6354 / 8542 |
| Branches | 50.7% | 22645 / 44673 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 68.7% | 4734 / 6895 |
| Functions | 53.5% | 1507 / 2816 |
| Branches | 40.3% | 3851 / 9562 |
Core HTML report | API HTML report
Commit 92f4638433dbde673d2042d13c23fb32ff629b42.
## Summary Compile `mx` as a Swift package so a sibling consumer can depend on it via `.package(path:)` for local-checkout development. - `Package.swift` vends the `Mx` library. - `MX_LOCAL_CHECKOUT` selects the mode: - When set, mx is a local sibling checkout and being compiled from local source. - Unset is reserved for a future binary release mechanism. - `swift-local` ci job builds the package in local mode Also fixes the AppleClang charconv error on `from_chars` / `to_chars` Base: `musicxml-4.0` (feeds #169).
gen-quality
|
This was referenced Jun 14, 2026
Closed
webern
added a commit
that referenced
this pull request
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I tried using AI to reverse-engineer the pseudo-hand-rolled original codegen. It worked but resulted in a 12k lines of unredeemable Python garbage with no room to maneuver from there. So, I started over and developed a
gen/program from the ground up using AI. I tried to keep it agnostic as to language target, so I think targeting other languages and use-cases is a real possibility now. Early on, I used Go and C as language targets to force the AI to think about extensibility. Those targets exist undergen/test, but are intended more asgen/program regression tests than for actual MusicXML use.For the replaced
mx::corecode, I prioritized compile time and better use of C++ features likevariantandoption. AI wanted to drop theezxmlabstraction and I guess it was time to let it go, sopugixmlis promoted tomx::coreinteraction.A
test-core-devtarget was used to allow the the AI to innovate onmx::corewithout worrying aboutmx::implandmx::api(in fact, I deleted those layers during code-gen). Then I replaced those layers and burned tokens to preserve themx::implalgorithms targeting the new set ofmx::coreclasses.References
gen/#157Follow-ups:
mx/apilayer. top priority is probably SMuFL