fix: floating HUD bar blocks interactions, can't be repositioned, and disappears during recording#730
Conversation
… Properly, and Disappears During Recording
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughElectron HUD overlay behavior now forces interactive mode while recording and updates taskbar visibility from recording state. The launch HUD bar drag hook now accepts recording input, resets its offset and transform when recording starts, and the native drag path includes recording. ChangesHUD recording behavior updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant LaunchWindow
participant useHudBarDrag
participant HudBarElement
LaunchWindow->>useHudBarDrag: recording
useHudBarDrag->>HudBarElement: reset offset and set translate3d(0px, 0px, 0)
LaunchWindow->>LaunchWindow: enable native HUD drag when recording
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
720c092 to
953d5ab
Compare
953d5ab to
04d30c1
Compare
|
up! if i click just once the click will be captured by the app but not the website i'm filming... |
Description
Fixes issue #728 three related HUD overlay bar bugs:
Disappears during recording – If the user drags the bar to the top before recording, the CSS
translate3doffset carried over into the compact recording window, pushing the bar content far off-screen and making controls inaccessible.Cannot be moved freely – During recording the window uses a compact layout but relied on JS-based CSS transform dragging, which only translated content within the window rather than moving the window itself.
Blocks nearby interactions –
setHudOverlayMousePassthrough()calledapplyHudOverlayBounds()redundantly on recording start, causing a double-bounds-set that could briefly leave the full-screen window interactive before shrinking it.No dock/taskbar presence – The HUD window had
skipTaskbar: truepermanently, making it impossible to find without Alt+Tab or Mission Control.Changes
electron/windows.ts– Removed redundantapplyHudOverlayBounds()in the recording branch ofsetHudOverlayMousePassthrough(). AddedsetSkipTaskbar(false)during recording so the window appears in the dock/taskbar.src/components/launch/hooks/useHudBarDrag.ts– Added arecordingprop. When recording starts, the drag offset is reset to(0,0)so any pre-recording position doesn't push the bar off-screen.src/components/launch/LaunchWindow.tsx– Passedrecordingto the drag hook. Enabled native OS window dragging (-webkit-app-region: drag) on the compact recording window so the user can freely reposition the bar.Testing
Summary by CodeRabbit
.gitignoreby removing outdated ignore rules.