Skip to content

fix: reject ragged multi-vector embeddings#2039

Open
pragnyanramtha wants to merge 3 commits into
weaviate:mainfrom
pragnyanramtha:pragnyan/reject-ragged-multi-vectors
Open

fix: reject ragged multi-vector embeddings#2039
pragnyanramtha wants to merge 3 commits into
weaviate:mainfrom
pragnyanramtha:pragnyan/reject-ragged-multi-vectors

Conversation

@pragnyanramtha
Copy link
Copy Markdown

Summary

  • validate multi-vector embeddings before gRPC byte packing
  • reject empty/ragged multi-vectors with WeaviateInvalidInputError instead of silently producing malformed bytes
  • add byte packing and query construction regression coverage

Validation

  • .venv/bin/pytest test/collection/test_byteops.py -q
  • .venv/bin/pytest test/test_get_vector_v4.py test/collection/test_queries.py -q
  • .venv/bin/ruff format --check weaviate/collections/grpc/shared.py test/collection/test_byteops.py
  • .venv/bin/flake8 weaviate/collections/grpc/shared.py test/collection/test_byteops.py
  • git diff --check

Copy link
Copy Markdown

@orca-security-eu orca-security-eu Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@pragnyanramtha pragnyanramtha marked this pull request as ready for review May 16, 2026 16:29
Copilot AI review requested due to automatic review settings May 16, 2026 16:29
@weaviate-git-bot
Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants