Add text2vec-digitalocean vectorizer module#570
Open
mpartipilo wants to merge 2 commits into
Open
Conversation
Adds support for the new text2vec-digitalocean vectorizer. The module shape mirrors text2vec-mistral exactly (model + baseURL + vectorizeClassName), so the existing serialization path is reused unchanged. Closes #569 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
bevzzz
requested changes
May 18, 2026
Per @bevzzz on #570: the `model + baseURL` test and the `sourceProperties` test both check the same thing — that a parameter is serialized correctly when set. Combine them into a single case that exercises all parameters at once. The empty/default test stays because it covers a structurally different scenario (the default `vectorizeClassName: false` payload with no other fields). This matches the leaner pattern used by other vectorizers in the same file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bevzzz
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text2vec-digitaloceanvectorizer module, mirroringtext2vec-mistral(shared shape:model+baseURL+vectorizeClassName)Kind.TEXT2VEC_DIGITALOCEANenum value and Gson type adapter inVectorConfigtext2vecDigitalOcean(), with fn, with name, with name + fn) and typed accessor helpers (isText2VecDigitalOcean/asText2VecDigitalOcean)API surface added
Text2VecDigitalOceanVectorizer— record with Lombok-style builder,baseUrl,model,sourceProperties,vectorIndex,quantizationVectorConfig.Kind.TEXT2VEC_DIGITALOCEAN— enum entry mapping to"text2vec-digitalocean"VectorConfig.text2vecDigitalOcean(...)— four factory overloadsVectorConfig.isText2VecDigitalOcean()/asText2VecDigitalOcean()— typed cast helpersTest plan
JSONTestasserting JSON serialization: default (empty config) and all-parameters-set (model + baseURL + sourceProperties)JSONTestpass (Tests run: 220, Failures: 0, Errors: 0)Review-feedback changes
Second commit (
c4eaf1b8) merges two of the original test cases per @bevzzz's review — themodel + baseURLcase and thesourcePropertiescase both checked the same thing (a parameter serializes correctly when set), so they're now one combined case that exercises all parameters at once. The empty/default case stays because it covers a structurally different payload. This matches the leaner pattern used by other vectorizers in the same file.Closes #569
Sibling PR (Python): weaviate/weaviate-python-client#2041
🤖 Generated with Claude Code