feat: add Dawn device toggles via dawnToggles#374
Open
pepperoni505 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set Dawn device (instance and adapter toggles aren't supported by this PR) toggles (full list here).
Our use case is the
ignore_imported_ahardwarebuffer_vulkan_image_size toggle: we hit validation errors in some Android emulator environments due to the driver issue documented in the file linked above. Rather than patch this repo to hardcode that one toggle, exposing the ability to set any toggle is the cleaner, more general solution.On the API shape: this adds a non-standard field to
GPUDeviceDescriptorrather than touching therequestDevicesignature. It's the most logical home, but I'm open to alternatives if you'd prefer it elsewhere.