[i,l,-r] build: bump version to 2.3.0-wavemm.1#7
Merged
Conversation
Two reasons: 1. Marks the artifact as a wavemm fork build, distinct from upstream 2.3.0 — useful when reading App Engine logs across versions or when troubleshooting a deploy-vs-upstream-bug question. 2. Forces the App Engine version_id (derived from the source ZIP hash) to change whenever we flip an env-var-only setting without touching Java source. App Engine doesn't allow mutating env vars on an existing version, and our terraform module derives version_id from source hash alone. Bumping the pom.xml between flag-only deploys keeps Terraform from trying to delete-and-recreate a version with the same ID (which App Engine rejects with 409). Subsequent flag-only deploys can bump the trailing integer (.2, .3, …) — bumping the patch number on every wavemm-side re-deploy is cheap and unambiguous in the App Engine version list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
phosphore
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Maven version to mark this as a wavemm fork build (distinct from upstream 2.3.0).
Also serves a practical purpose: our App Engine
version_idis derived from the source ZIP hash, and App Engine doesn't allow mutating env vars on an existing version. When we flip env-var-only settings (e.g.,SLACK_NOTIFICATIONS_ENABLED) without touching Java source, Terraform tries to delete-and-recreate a version with the same ID, which App Engine rejects with 409.Bumping the trailing patch (.1, .2, .3, ...) on every flag-only redeploy is cheap and gives an unambiguous progression in the App Engine version list. The next env-var-only redeploy will bump to
2.3.0-wavemm.2.🤖 Generated with Claude Code