Skip to content

fix(web): keep healthz alive on corrupt proposals#279

Open
plind-junior wants to merge 1 commit into
testfrom
fix/review-ui-healthz-corrupt-yaml
Open

fix(web): keep healthz alive on corrupt proposals#279
plind-junior wants to merge 1 commit into
testfrom
fix/review-ui-healthz-corrupt-yaml

Conversation

@plind-junior

Copy link
Copy Markdown
Collaborator

fixes review-ui startup timeouts where /healthz crashed while parsing a corrupt pending proposal yaml file, for example yaml.reader.ReaderError: unacceptable character #x0080.

changes:

  • make /healthz count pending proposal files in .vouch/proposed/ instead of deserializing every proposal
  • keep the detailed queue/api behavior unchanged; unreadable proposal files are still skipped and logged there
  • add a regression test that writes the invalid \x80 control character and confirms /healthz remains healthy
  • document the review-ui health fix in the changelog

verified:

  • /home/a/Dev/plind-junior/vouch/.venv/bin/python -m pytest tests/test_web.py tests/test_web_e2e.py -q
  • /home/a/Dev/plind-junior/vouch/.venv/bin/python -m ruff check src/vouch/web/server.py tests/test_web.py
  • /home/a/Dev/plind-junior/vouch/.venv/bin/python -m mypy src

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ed28363-91e5-4ce7-b5cf-edbdee088760

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/review-ui-healthz-corrupt-yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant