fix(context): compute require_citations gate after max_chars budget

[Yurii214]

Summary

• move the require_citations / uncited_items computation to after the max_chars budget step in build_context_pack, so the quality gate only considers claims actually returned in the pack
• add regression tests covering both the subset invariant (uncited_items ⊆ returned ids) and the case where budget trimming removes all uncited claims before the gate runs

fixes #174.

Why

before this change, uncited was computed over the full pre-budget item list. tail items dropped by max_chars could still appear in quality.uncited_items and trigger a require_citations failure even though the caller never received those claims.

Test plan

• pytest tests/test_context.py -q
• ruff check src tests
• mypy src (CI)

Made with Cursor

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f3021d9-e780-42e0-bff8-583777b00e24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Yurii214]

@plind-junior Hi — gentle ping on this when you have a moment.

Fixes #174 — require_citations / uncited_items are now computed after the max_chars budget trim in build_context_pack(), so the quality gate only considers claims actually returned to the caller.

Rebased onto latest test (eda296b) and CI is green. Happy to adjust if you’d prefer a different approach.

Thanks for maintaining vouch 🙏