Feat/235 mcp publish skills#260
Open
jsdevninja wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f9343fd to
19de153
Compare
19de153 to
dd3f87d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds
mcp.publish_skillsto.vouch/config.yaml(defaulttrue) and wires it throughkb.list_skills,kb.get_skill,kb.capabilities, MCP, JSONL, and CLI (vouch list-skills,vouch get-skill). Also ships the skill-discovery surface itself — scanning project-local and user-global.claude/skillsand.claude/commandstrees — which was scoped onupstream/feat/hot-memory-skillsbut not yet onmain.Why
Closes #235(#235). For a company-brain KB, the skill catalogue itself can be sensitive. gbrain already gates this with
mcp.publish_skills; vouch needs the same knob so MCP callers can't enumerate every slash command andSKILL.mdwhen the operator wants the catalogue hidden. Default-on keeps existing KBs unchanged.What might break
No breaking changes for existing
.vouch/directories. KBs with nomcp:block behave exactly as today (publish_skillsdefaults totrue). On-disk layout, bundle format, and audit-log shape are untouched.kb.list_skillsandkb.get_skillare new methods — clients that don't call them are unaffected. The only behavioural change for opted-in configs is when an operator explicitly setsmcp.publish_skills: false.VEP
Not required — config knob + two new read-only
kb.*methods; no object-model, on-disk layout, bundle, or audit-log changes.Tests
make checkpasses locally (lint + mypy + pytest)CHANGELOG.mdupdated under## [Unreleased]