feat(cli): prompt for node mismatch reinstall#1666
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
liangmiQwQ
changed the title
liangmiQwQ
force-pushed
the
codex/resolve-1598-node-mismatch
branch
from
65d56b1 to
2be7684
Compare
liangmiQwQ
changed the title
liangmiQwQ
force-pushed
the
codex/resolve-1598-node-mismatch
branch
from
daa6bf3 to
12090e6
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12090e6a39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| return true; | ||
| } | ||
|
|
||
| if !std::io::stdin().is_terminal() || std::env::var_os("CI").is_some() { |
There was a problem hiding this comment.
The logic code for determining non-interactive mode has been repeatedly written in many places with the same logic. Can this logic code be extracted and placed in crates/vite_shared to be reused?
|
@liangmiQwQ Could you record a video and submit it in the PR description to demonstrate the new interaction process? |
2 participants
Close #1598
This PR adds a prompt logic for all up-to-date global packages with a Node.js version mismatch to ask users whether to reinstall packages with the current Node. The prompt defaults to
N.This PR also adds
--reinstall-node-mismatchand--ignore-node-mismatch. In CI or non-interactive environments, Reinstall will be skipped the and warns that users can pass--reinstall-node-mismatchto force it.🤖 Generated with Codex