Skip to content

fix: gui CI after closure lifetime merge#63

Merged
JalonSolov merged 1 commit into
vlang:mainfrom
GGRei:fix/ci-after-closure-lifetime-merge
Jun 22, 2026
Merged

fix: gui CI after closure lifetime merge#63
JalonSolov merged 1 commit into
vlang:mainfrom
GGRei:fix/ci-after-closure-lifetime-merge

Conversation

@GGRei

@GGRei GGRei commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

This updates the v-gui CI after the closure lifetime/reclaim work landed in V.

The Windows job was still using an outdated V compiler path, which could miss the new closure lifetime/reclaim API used by v-gui. This PR makes the Windows job resolve and build/cache the current V compiler revision, so it stays aligned with upstream V.

It also refreshes the Windows dependency cache keys from the resolved V/vglyph revisions, so compiler or dependency updates do not keep reusing stale caches.

Finally, it reduces CI noise and runtime by avoiding warning-fatal full example sweeps and duplicate full example rebuilds on push runs.

Changes

  • Resolve the current V compiler revision in Windows CI.
  • Cache the Windows V compiler by exact V revision.
  • Refresh Windows vcpkg and vglyph cache keys from the resolved V/vglyph revisions.
  • Keep changed-example -W checks on pull requests.
  • Avoid full example v -check sweeps for .v examples, since those currently fail on transitive gui/vglyph diagnostics rather than example-local syntax.
  • Run full example compilation on push only once, using non warning-fatal mode.
  • Format examples/showcase.v so the CI format check passes.

Notes

This PR does not change the closure lifetime/reclaim behavior itself.

The .v examples are still covered by compilation checks. The removed/relaxed parts were CI warning-fatal or duplicate paths that were causing false failures or unnecessary rebuild time.

Tests

v fmt -verify examples/showcase.v
v -check examples/_check.vsh
git diff --check

@JalonSolov JalonSolov merged commit 3a3ba3c into vlang:main Jun 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants