fix: gui CI after closure lifetime merge#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the v-gui CI after the closure lifetime/reclaim work landed in V.
The Windows job was still using an outdated V compiler path, which could miss the new closure lifetime/reclaim API used by v-gui. This PR makes the Windows job resolve and build/cache the current V compiler revision, so it stays aligned with upstream V.
It also refreshes the Windows dependency cache keys from the resolved V/vglyph revisions, so compiler or dependency updates do not keep reusing stale caches.
Finally, it reduces CI noise and runtime by avoiding warning-fatal full example sweeps and duplicate full example rebuilds on push runs.
Changes
vcpkgandvglyphcache keys from the resolved V/vglyph revisions.-Wchecks on pull requests.v -checksweeps for.vexamples, since those currently fail on transitive gui/vglyph diagnostics rather than example-local syntax.examples/showcase.vso the CI format check passes.Notes
This PR does not change the closure lifetime/reclaim behavior itself.
The
.vexamples are still covered by compilation checks. The removed/relaxed parts were CI warning-fatal or duplicate paths that were causing false failures or unnecessary rebuild time.Tests