Enhance PdfViewer download functionality#1288
Merged
Merged
Conversation
Refactored the `DownloadPdf` implementation in `PdfViewer.razor.cs` and `PdfViewerJsInterop.cs` to support downloading PDFs from both base64 data and validated URLs. Added error handling for empty URLs and introduced unique filename generation for downloads. Updated JavaScript functions in `blazor.bootstrap.pdf.js` to align with the new interop methods and improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
DownloadPdfimplementation inPdfViewer.razor.csandPdfViewerJsInterop.csto support downloading PDFs from both base64 data and validated URLs. Added error handling for empty URLs and introduced unique filename generation for downloads. Updated JavaScript functions inblazor.bootstrap.pdf.jsto align with the new interop methods and improve maintainability.