feat: consolidate trustee and kyverno overrides via extraValueFiles#85
Open
butler54 wants to merge 1 commit into
Open
feat: consolidate trustee and kyverno overrides via extraValueFiles#85butler54 wants to merge 1 commit into
butler54 wants to merge 1 commit into
Conversation
Remove duplicated inline overrides across profiles by consolidating common configuration into shared override files loaded via extraValueFiles. Changes: - Fix overrides/values-trustee.yaml: remove FIXME global.coco.secured, add kbs.admin.format and kbs.https.enabled - Create overrides/values-kyverno.yaml with securityContext nulls and CRD/report disables for OpenShift compatibility - Wire both override files via extraValueFiles in values-simple.yaml, values-baremetal.yaml, values-baremetal-gpu.yaml, values-trusted-hub.yaml - Remove inline duplicates (admin.format, secured, https, secretResources, all kyverno securityContext/CRD overrides) - Keep profile-specific inline overrides: tdx, collateralService, gpu.enabled, backgroundController.resources Reduces ~25 lines of duplication per profile while maintaining profile-specific customization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate duplicated inline overrides across profiles by using the VP framework's
extraValueFilesmechanism.Changes
Trustee overrides:
overrides/values-trustee.yaml: remove FIXMEglobal.coco.secured, addkbs.admin.formatandkbs.https.enabledextraValueFilesin:values-simple.yaml,values-baremetal.yaml,values-baremetal-gpu.yaml,values-trusted-hub.yamlKyverno overrides:
overrides/values-kyverno.yamlwith securityContext nulls + CRD/report disables for OpenShift compatibilityextraValueFilesin:values-simple.yaml,values-baremetal.yaml,values-baremetal-gpu.yamlbackgroundController.resourcesinline in baremetal/baremetal-gpu onlyImpact
Reduces ~25 lines of duplication per profile while maintaining profile-specific customization. No functional change — same configuration values, just DRYer organization.
Relates to Wave 1 PR 1B of the bare metal attestation hardening plan.