fix(codeapi-chart): support sandbox runner scale to zero#11
Merged
Conversation
dc1e56a to
607e019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Fixes
This PR lets the service-worker start when
codeapi-sandbox-runneris owned by an external autoscaler.The chart already has
workerSandbox.sandboxRunner.externalAutoscaler=truefor KEDA-style ownership. With this PR, that existing setting also skips the service-worker init container that waits for a live sandbox runner. Default installs are unchanged.Branch Coverage
main607e019wait-for-sandbox-runnerbased on existingworkerSandbox.sandboxRunner.externalAutoscaler.Verification
Current head:
helm template codeapi helm/codeapi -n codeapi --set executionManifest.privateKey=dummy --set executionManifest.publicKey=dummy --show-only templates/worker-sandbox-deployment.yaml | rg "name: wait-for-"-> renderswait-for-redisandwait-for-sandbox-runner.helm template codeapi helm/codeapi -n codeapi --set executionManifest.privateKey=dummy --set executionManifest.publicKey=dummy --set workerSandbox.sandboxRunner.externalAutoscaler=true --show-only templates/worker-sandbox-deployment.yaml | rg "name: wait-for-"-> renderswait-for-redisonly.git diff --check uzh/main...HEAD-> pass.GitHub Actions:
API Unit Testson607e019-> running after force-push.Service Unit Testson607e019-> running after force-push.Earlier branch verification:
Security / Privacy
Blocking Before Merge
607e019.workerSandbox.sandboxRunner.externalAutoscaleras the scale-to-zero signal.Follow-Up After Merge