Skip to content

shred: two refactorings#12780

Open
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:shred_remove_fn
Open

shred: two refactorings#12780
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:shred_remove_fn

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR applies two refactorings:

  • it removes create_compatible_sequence which simply delegates to create_test_compatible_sequence and calls this function instead
  • it changes the type of the random_source param of create_test_compatible_sequence from Option<&RefCell<File>> to &RefCell<File> as the function is never called with None

@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.73%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 321 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 52.3 ms 49.6 ms +5.5%
Simulation ls_recursive_wide_tree[(10000, 1000)] 34.3 ms 33 ms +3.96%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:shred_remove_fn (ec33bb8) with main (7a944ce)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/io-errors (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/dd/no-allocate is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant