Skip to content

pr: uutils pr accepts -W 0 and -w 0 while gnu pr rejects it#12779

Merged
cakebaker merged 6 commits into
uutils:mainfrom
Devel08:fix-issue-12767
Jun 11, 2026
Merged

pr: uutils pr accepts -W 0 and -w 0 while gnu pr rejects it#12779
cakebaker merged 6 commits into
uutils:mainfrom
Devel08:fix-issue-12767

Conversation

@Devel08

@Devel08 Devel08 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This PR resolves #12767

@HackingRepo

Copy link
Copy Markdown

@Devel08 add a test also for -W not just -w alone for we confirm all

@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 6%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 321 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 562.5 KB 615.6 KB -8.62%
Simulation single_date_now 82.7 µs 85.5 µs -3.3%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Devel08:fix-issue-12767 (5a4d17e) with main (c77bf21)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (3176027) during the generation of this report, so c77bf21 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@Devel08

Devel08 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@HackingRepo Oops, I thought that -W and -w are the same, thanks

@cakebaker cakebaker merged commit 4505d51 into uutils:main Jun 11, 2026
172 of 175 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gnucompability(pr): -W 0 and -w 0 uutils accept it and gnu rejects it

3 participants