Skip to content

Minor changes to reduce number of messages #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavyLandman merged 4 commits into from
May 28, 2026
+2 −4
Merged

Minor changes to reduce number of messages #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1eee4a6
Minor changes to reduce number of messages
PaulKlint May 27, 2026
b7f6d39
Filtering messages at the level of the Rascal typechcker
PaulKlint May 28, 2026
395e8e3
Only report errors for modules with status "checked".
PaulKlint May 28, 2026
f79cc94
Reverted change in reportModuleMessages
PaulKlint May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/rascalmpl/compiler/lang/rascalcore/check/Checker.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ list[ModuleMessages] check(list[loc] moduleLocs, RascalCompilerConfig compilerCo
list[ModuleMessages] reportModuleMessages(ModuleStatus ms){
moduleIds = domain(ms.moduleLocs);
messagesNoModule = {*ms.messages[mid] | MODID mid <- ms.messages, (mid notin moduleIds || mid notin ms.moduleLocs)} + toSet(ms.pathConfig.messages);
msgs = [ program(ms.moduleLocs[mid], (ms.messages[mid] ? {}) + messagesNoModule) | MODID mid <- moduleIds ];
msgs = [ program(mid, (ms.messages[mid] ? {}) + messagesNoModule) | MODID mid <- moduleIds ];
if(isEmpty(msgs) && !isEmpty(messagesNoModule)){
msgs = [ program(|unknown:///|, messagesNoModule) ];
}
Expand Down
1 change: 0 additions & 1 deletion src/org/rascalmpl/compiler/lang/rascalcore/check/CheckerCommon.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ ModuleStatus removeTModel(MODID candidate, ModuleStatus ms, bool updateBOMneeded
ms = deleteProperty(candidate, ms, bom_update_needed());
<found, tplLoc> = getTPLWriteLoc(candidate, pcfg);
tm = ms.tmodels[candidate];
//tm.messages = toList(toSet(tm.messages) + ms.messages[candidate]); // TODO needed ?
ms = addProperty(candidate, ms, tpl_saved());
if(ms.compilerConfig.verbose) println("Saving tmodel for <moduleId2moduleName(candidate)> before removing from cache");
try {
Expand Down
3 changes: 1 addition & 2 deletions src/org/rascalmpl/compiler/lang/rascalcore/check/Import.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,7 @@ ModuleStatus doSaveModule(set[MODID] component, map[MODID,set[MODID]] m_imports,
m1.specializedFacts = (key : tm.specializedFacts[key] | key <- tm.specializedFacts, isContainedInComponentScopes(key, tm.logical2physical), any(fms <- filteredModuleScopes, isContainedIn(key, fms)));
m1.facts += m1.specializedFacts;

// m1.messages = [ msg | msg <- tm.messages, msg.at.path == currentModule.path || msg is error ];
m1.messages = tm.messages;
m1.messages = [msg | msg <- tm.messages, isContainedIn(msg.at, currentModule, tm.logical2physical)];
ms.messages[currentModule] = toSet(m1.messages);

filteredModuleScopePaths = {ml.path |loc ml <- filteredModuleScopes};
Expand Down
Loading