fix(link): guard IME composition-commit Enter (keyCode 229) in floating link#5048
Merged
zbeyens merged 1 commit intoJun 30, 2026
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: b4c8eaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixfeng33
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
useFloatingLinkEntersubmits the floating link on any keydown that reaches the global hotkey handler withe.key === 'Enter':On Safari/WebKit with a Japanese IME, the keydown that commits a composition arrives with
e.key === 'Enter',e.keyCode === 229, ande.isComposing === false. So when a user types a CJK link label and presses Enter to confirm the composition, this handler treats it as a submit and closes the floating link mid-composition.Fix
Skip the IME composition-commit Enter, the same way the rest of the repo already does:
packages/udecode/cmdk/src/cmdk.tsx:if (!e.nativeEvent.isComposing && e.keyCode !== 229), with a comment thatisComposingis not set for the Japanese IME + Safari combination.packages/table/src/react/onKeyDownTable.ts:const compositeKeyCode = 229; ... event.which === compositeKeyCode.A normal Enter (
keyCode === 13,isComposing === false) still submits.Notes
The vendored
react-hotkeysmatches byevent.code, which is still'Enter'on the IME-commit key, so the callback is where the guard belongs. I kept it at the call site to match the existingcmdk/tableguards instead of touching the fork.keyCode is not reproducible in jsdom (it reads as 0), so I verified this by the same logic as the existing guards rather than a unit test, which is also why those guards have none.