refactor(runway): collapse orchestrator into single-service domain#272
Draft
behinddwalls wants to merge 1 commit into
Draft
refactor(runway): collapse orchestrator into single-service domain#272behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary
### Why?
Runway only ever had a single service, so the per-domain `gateway/` + `orchestrator/` split wrapped it in an empty service layer. Making the runway domain *be* the service removes that indirection and matches how runway actually works — a consumer-only landing service with no gateway.
### What?
Collapses the `orchestrator` service segment out of the runway domain:
- `runway/orchestrator/controller/*` → `runway/controller/*`
- `api/runway/orchestrator/{proto,protopb}` → `api/runway/{proto,protopb}`
- `example/runway/orchestrator/{client,server}` → `example/runway/{client,server}`
The proto package becomes `uber.runway` (was `uber.runway.orchestrator`) and the RPC service `RunwayOrchestrator` becomes `Runway`. Server/client identifiers, metric scope, and the `ServiceName` ping field follow suit. Build tooling (`tool/proto`, `Makefile` targets, `docker-compose.yml`, `Dockerfile`) and docs (`CLAUDE.md`, `runway/README.md`, runway workflow RFC) are updated, documenting the single-service-domain pattern.
## Test Plan
- ✅ `make build`
- ✅ `make proto` + `make gazelle` (idempotent)
- ✅ runway tests: `//runway/...`, `//api/runway/...`, `//example/runway/...`
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Runway only ever had a single service, so the per-domain
gateway/+orchestrator/split wrapped it in an empty service layer. Making the runway domain be the service removes that indirection and matches how runway actually works — a consumer-only landing service with no gateway.What?
Collapses the
orchestratorservice segment out of the runway domain:runway/orchestrator/controller/*→runway/controller/*api/runway/orchestrator/{proto,protopb}→api/runway/{proto,protopb}example/runway/orchestrator/{client,server}→example/runway/{client,server}The proto package becomes
uber.runway(wasuber.runway.orchestrator) and the RPC serviceRunwayOrchestratorbecomesRunway. Server/client identifiers, metric scope, and theServiceNameping field follow suit. Build tooling (tool/proto,Makefiletargets,docker-compose.yml,Dockerfile) and docs (CLAUDE.md,runway/README.md, runway workflow RFC) are updated, documenting the single-service-domain pattern.Test Plan
make buildmake proto+make gazelle(idempotent)//runway/...,//api/runway/...,//example/runway/...