@doc and @meta annotations#446
Merged
Merged
Conversation
fc420c4 to
1882f30
Compare
| let mut children = node.into_children(); | ||
| let keyword = children.consume_any(); | ||
| let annotation_category = match keyword.as_rule() { | ||
| Rule::ANNOTATION_ABSTRACT => AnnotationCategory::Abstract, |
Member
There was a problem hiding this comment.
Oh fun can we dissolve the core-specific IR for these now?
Member
Author
There was a problem hiding this comment.
No, the Meta category carries a StringLiteral in typeql but a parsed unescaped String in core.
| // FUNCTION DEFINITION ========================================================= | ||
|
|
||
| definition_function = { FUN ~ function_signature ~ COLON ~ function_block } | ||
| definition_function = { FUN ~ function_signature ~ annotations? ~ COLON ~ function_block } |
Member
There was a problem hiding this comment.
so how do we expect to write this?
define
fun get_name($p: person) -> { name}
@doc("..."):
match $p has name $name;
return { $name };
?
759c64a to
6e8b18c
Compare
d4f9e02 to
ccbd308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product change and motivation
We implement
@doc("docstring")and@meta("key", "value")schema annotations. These annotations can be attached to types and capabilities i.e.owns,plays,relates, andsub:These annotations can also be attached to function definitions. They go at the end of the signature, before the colon introducing the body of the function:
Implementation