Remove unconditional Send implementation for Service#232
Open
robin-nitrokey wants to merge 1 commit into
Open
Conversation
The unconditional Send implementation for Service is unsound because we don’t know anything about the platform and dispatch implementations. Instead, runners should add a manual Send implementation for the required structs if necessary. For example, we have to add a manual Send implementation for virt::Store. This is technically not correct but currently the only way to make it work and still better than the implementation for Service. Fixes: #211
sosthene-nitrokey
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unconditional Send implementation for Service is unsound because we don’t know anything about the platform and dispatch implementations. Instead, runners should add a manual Send implementation for the required structs if necessary. For example, we have to add a manual Send implementation for virt::Store. This is technically not correct but currently the only way to make it work and still better than the implementation for Service.
Fixes: #211