Skip to content

feat(event): add parent hash in the block event #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clarkchen wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −1
Open

feat(event): add parent hash in the block event #6294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde47df
feat: add parent hash in the block event
clarkchen Apr 21, 2025
4ff2223
Merge branch 'tronprotocol:develop' into develop
clarkchen Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion common/src/main/java/org/tron/common/logsfilter/trigger/BlockLogTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ public class BlockLogTrigger extends Trigger {
@Setter
private List<String> transactionList = new ArrayList<>();


Copy link
Copy Markdown
Collaborator

@0xbigapple 0xbigapple May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NIT] Double blank line before the new field.

@Getter
Copy link
Copy Markdown
Collaborator

@0xbigapple 0xbigapple May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SHOULD] Add an assertion that parentHash is populated by the capsule constructor.

@Setter
private String parentHash;

public BlockLogTrigger() {
setTriggerName(Trigger.BLOCK_TRIGGER_NAME);
}
Expand All @@ -45,6 +50,10 @@ public String toString() {
.append(", latestSolidifiedBlockNumber: ")
.append(latestSolidifiedBlockNumber)
.append(", transactionList: ")
.append(transactionList).toString();
.append(transactionList)
.append(", parentHash: ")
.append(parentHash)
.toString();

Copy link
Copy Markdown
Collaborator

@0xbigapple 0xbigapple May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NIT] Trailing blank line inside the toString() method body.

}
}
1 change: 1 addition & 0 deletions framework/src/main/java/org/tron/common/logsfilter/capsule/BlockLogTriggerCapsule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public BlockLogTriggerCapsule(BlockCapsule block) {
block.getTransactions().forEach(trx ->
blockLogTrigger.getTransactionList().add(trx.getTransactionId().toString())
);
blockLogTrigger.setParentHash(block.getParentHash().toString());
}

public void setLatestSolidifiedBlockNumber(long latestSolidifiedBlockNumber) {
Expand Down
Loading