feat(run-ops): automatically migrate the dedicated run-ops database#4150
Merged
Conversation
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (11)
📜 Recent review details⏰ Context from checks skipped due to timeout. (24)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description covers the change well, but it misses required template items like Closes #issue, checklist, and Screenshots. |
Add the missing template sections: Closes #, the checklist items, a Testing summary, a Changelog entry, and Screenshots. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly states the main change: automatically migrating the dedicated run-ops database. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
runops/pr11-auto-migrate-new-db
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/webapp/app/v3/runOpsMigration/splitMode.server.ts (1)
30-36: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winStale diagnostic message after canonicalization.
newUrlis now resolved viarunOpsNewDatabaseUrl(RUN_OPS_DATABASE_URL ?? TASK_RUN_DATABASE_URL), but the warning still only namesTASK_RUN_DATABASE_URL, which will mislead operators debugging a misconfigured split.📝 Proposed message update
deps.logger?.warn( - "RUN_OPS_SPLIT_ENABLED is on but TASK_RUN_LEGACY_DATABASE_URL / TASK_RUN_DATABASE_URL are not both set; staying single-DB." + "RUN_OPS_SPLIT_ENABLED is on but TASK_RUN_LEGACY_DATABASE_URL / (RUN_OPS_DATABASE_URL or TASK_RUN_DATABASE_URL) are not both set; staying single-DB." );Also applies to: 74-74
🧹 Nitpick comments (2)
internal-packages/run-ops-database/scripts/migrate.mjs (2)
14-37: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueInline
#comments aren't stripped in the .env parser.The regex captures everything up to end-of-line, so
KEY=value # notebecomesvalue # noteinstead ofvalue. If any.envused for local/dev resolution has inline comments on a DB URL line, the trailing comment gets appended to the connection string.Proposed fix to strip unquoted inline comments
- let value = match[2]; + let value = match[2]; + if (!(value.startsWith('"') || value.startsWith("'"))) { + value = value.replace(/\s+#.*$/, ""); + }
68-78: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winSurface
spawnSyncerrors for easier diagnosis.If the
prismabinary can't be spawned (e.g. missing fromPATH),result.erroris set but never logged; the script just exits 1 with no explanation of why.Proposed fix to log spawn errors
const result = spawnSync("prisma", ["migrate", subcommand, "--schema", "prisma/schema.prisma"], { cwd: packageRoot, stdio: "inherit", env: { ...process.env, RUN_OPS_DATABASE_URL: databaseUrl, RUN_OPS_DATABASE_DIRECT_URL: directUrl, }, }); + +if (result.error) { + console.error(`Failed to spawn \`prisma\`: ${result.error.message}`); +} process.exit(result.status ?? 1);
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 021601b1-e533-4f2b-b893-8960e0a7b25b
📒 Files selected for processing (10)
.server-changes/run-ops-auto-migrate.mdapps/webapp/app/db.server.tsapps/webapp/app/env.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runStore.server.tsdocker/scripts/entrypoint.shinternal-packages/run-ops-database/package.jsoninternal-packages/run-ops-database/scripts/migrate.mjs
📜 Review details
⏰ Context from checks skipped due to timeout. (22)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
internal-packages/run-ops-database/scripts/migrate.mjsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
internal-packages/run-ops-database/scripts/migrate.mjsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
When adding
zodto any package, use the exact repository-pinned version (3.25.76) and never a different version or a range.
Files:
internal-packages/run-ops-database/package.json
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
🧠 Learnings (20)
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/run-ops-auto-migrate.md
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/runsReplicationInstance.server.ts
📚 Learning: 2026-05-20T17:21:18.543Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3678
File: apps/webapp/app/entry.server.tsx:0-0
Timestamp: 2026-05-20T17:21:18.543Z
Learning: In env.server.ts (Zod env schema), any environment variable you plan to access via the typed `env` export (e.g., `env.SENTRY_DSN`) must be explicitly declared in the schema. For `SENTRY_DSN`, include `SENTRY_DSN: z.string().optional()`; otherwise switching from `process.env.SENTRY_DSN` to `env.SENTRY_DSN` will fail TypeScript typechecking.
Applied to files:
apps/webapp/app/env.server.ts
📚 Learning: 2026-06-01T11:37:08.569Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3754
File: apps/webapp/app/env.server.ts:1104-1129
Timestamp: 2026-06-01T11:37:08.569Z
Learning: In apps/*/app/env.server.ts, any new background/periodic worker feature flag should hard-default to "0" (explicit opt-in) rather than inheriting from a parent flag (e.g., avoid defaulting to process.env.TRIGGER_MOLLIFIER_ENABLED ?? "0"). Inheriting can cause the new worker to auto-start on upgrade for deployments that already enabled the parent flag, turning on unexpected background load without an explicit rollout. Each worker component must require its own dedicated env var and default it explicitly to "0" (e.g., TRIGGER_MOLLIFIER_STALE_SWEEP_ENABLED defaults to "0" unless explicitly set to enable that worker).
Applied to files:
apps/webapp/app/env.server.ts
🔇 Additional comments (10)
internal-packages/run-ops-database/scripts/migrate.mjs (2)
39-44: LGTM!
46-62: LGTM!internal-packages/run-ops-database/package.json (1)
30-31: LGTM!docker/scripts/entrypoint.sh (1)
16-29: LGTM!.server-changes/run-ops-auto-migrate.md (1)
1-7: LGTM!apps/webapp/app/env.server.ts (1)
135-147: LGTM!Also applies to: 1734-1735, 2112-2118
apps/webapp/app/db.server.ts (1)
13-13: LGTM!Also applies to: 240-240, 281-281
apps/webapp/app/services/runsReplicationInstance.server.ts (1)
2-2: LGTM!Also applies to: 175-175
apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.ts (1)
8-8: LGTM!Also applies to: 452-452
apps/webapp/app/v3/runStore.server.ts (1)
79-79: 🩺 Stability & AvailabilityROUTING_ENABLED already inherits the split flag
runOpsTopologygates the run-ops clients behindenv.RUN_OPS_SPLIT_ENABLED, so this guard is not missing here.> Likely an incorrect or invalid review comment.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
internal-packages/run-ops-database/scripts/migrate.mjs (1)
48-72: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winFail fast on unresolved
${VAR}refs inRUN_OPS_DATABASE_URL. Missing substitutions currently collapse to"", which can turnRUN_OPS_DATABASE_URL=${DATABASE_URL}into a skipped migration and let startup continue without migrating the run-ops DB.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 96429200-4121-47e2-9f41-85dcbd802ab4
📒 Files selected for processing (10)
.server-changes/run-ops-auto-migrate.mdapps/webapp/app/db.server.tsapps/webapp/app/env.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsdocker/scripts/entrypoint.shinternal-packages/run-ops-database/scripts/migrate.mjs
✅ Files skipped from review due to trivial changes (1)
- .server-changes/run-ops-auto-migrate.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docker/scripts/entrypoint.sh
📜 Review details
⏰ Context from checks skipped due to timeout. (17)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsinternal-packages/run-ops-database/scripts/migrate.mjsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsinternal-packages/run-ops-database/scripts/migrate.mjsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/runsReplicationInstance.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/runsReplicationInstance.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
apps/webapp/test/runsReplicationInstance.test.ts
**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{js,jsx,ts,tsx}: Keep test files beside the files under test and write tests with descriptivedescribeanditblocks.
Avoid mocks or stubs in tests, and use helpers from@internal/testcontainerswhen Redis or Postgres are needed.
Files:
apps/webapp/test/runsReplicationInstance.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/runsReplicationInstance.test.ts
🧠 Learnings (23)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/db.server.tsapps/webapp/app/env.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/runsReplicationInstance.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/runsReplicationInstance.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/runsReplicationInstance.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/runsReplicationInstance.test.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/runsReplicationInstance.server.ts
📚 Learning: 2026-05-20T17:21:18.543Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3678
File: apps/webapp/app/entry.server.tsx:0-0
Timestamp: 2026-05-20T17:21:18.543Z
Learning: In env.server.ts (Zod env schema), any environment variable you plan to access via the typed `env` export (e.g., `env.SENTRY_DSN`) must be explicitly declared in the schema. For `SENTRY_DSN`, include `SENTRY_DSN: z.string().optional()`; otherwise switching from `process.env.SENTRY_DSN` to `env.SENTRY_DSN` will fail TypeScript typechecking.
Applied to files:
apps/webapp/app/env.server.ts
📚 Learning: 2026-06-01T11:37:08.569Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3754
File: apps/webapp/app/env.server.ts:1104-1129
Timestamp: 2026-06-01T11:37:08.569Z
Learning: In apps/*/app/env.server.ts, any new background/periodic worker feature flag should hard-default to "0" (explicit opt-in) rather than inheriting from a parent flag (e.g., avoid defaulting to process.env.TRIGGER_MOLLIFIER_ENABLED ?? "0"). Inheriting can cause the new worker to auto-start on upgrade for deployments that already enabled the parent flag, turning on unexpected background load without an explicit rollout. Each worker component must require its own dedicated env var and default it explicitly to "0" (e.g., TRIGGER_MOLLIFIER_STALE_SWEEP_ENABLED defaults to "0" unless explicitly set to enable that worker).
Applied to files:
apps/webapp/app/env.server.ts
🔇 Additional comments (9)
apps/webapp/app/env.server.ts (2)
135-153: LGTM!
135-153: 🎯 Functional CorrectnessNo remaining references to the removed
TASK_RUN_*env vars orrunOpsNewDatabaseUrl.apps/webapp/app/db.server.ts (1)
239-263: LGTM!Also applies to: 277-282
apps/webapp/app/services/runsReplicationInstance.server.ts (1)
175-175: LGTM!apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.ts (1)
451-452: LGTM!apps/webapp/app/v3/runOpsMigration/splitMode.server.ts (1)
32-36: LGTM!Also applies to: 68-80
apps/webapp/app/v3/runStore.server.ts (1)
79-79: LGTM!apps/webapp/test/runsReplicationInstance.test.ts (1)
129-141: LGTM!internal-packages/run-ops-database/scripts/migrate.mjs (1)
1-57: LGTM on the visible logic (single-sourceRUN_OPS_DATABASE_URLresolution, safe no-op skip+exit 0 when unset).
d-cs
force-pushed
the
runops/pr11-auto-migrate-new-db
branch
from
0ea3402 to
502471c
Compare
d-cs
changed the base branch from
main
to
fix/runs-replication-leader-lock-per-slot
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ddab1882-038d-493e-b301-fdaf8ac5a2f7
📒 Files selected for processing (17)
.env.example.server-changes/fix-replication-leader-lock-per-slot.md.server-changes/run-ops-auto-migrate.mdapps/webapp/app/db.server.tsapps/webapp/app/env.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsdocker/scripts/entrypoint.shinternal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.tsinternal-packages/run-ops-database/package.jsoninternal-packages/run-ops-database/prisma/schema.prismainternal-packages/run-ops-database/scripts/migrate.mjsinternal-packages/testcontainers/src/utils.ts
💤 Files with no reviewable changes (1)
- .env.example
✅ Files skipped from review due to trivial changes (2)
- .server-changes/run-ops-auto-migrate.md
- .server-changes/fix-replication-leader-lock-per-slot.md
🚧 Files skipped from review as they are similar to previous changes (12)
- internal-packages/run-ops-database/package.json
- internal-packages/testcontainers/src/utils.ts
- apps/webapp/test/runsReplicationInstance.test.ts
- docker/scripts/entrypoint.sh
- apps/webapp/app/v3/runStore.server.ts
- apps/webapp/app/services/runsReplicationInstance.server.ts
- internal-packages/run-ops-database/prisma/schema.prisma
- apps/webapp/app/db.server.ts
- apps/webapp/app/v3/runOpsMigration/splitMode.server.ts
- internal-packages/run-ops-database/scripts/migrate.mjs
- apps/webapp/app/env.server.ts
- apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (25)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: audit
⚠️ CI failures not shown inline (2)
GitHub Actions: 📝 Agent Instructions Audit / audit: feat(run-ops): automatically migrate the dedicated run-ops database
Conclusion: failure
##[group]Run anthropics/claude-code-action@428971d2ecd6e3a7cb0ee0da2a3a8b33fdb3678d
with:
anthropic_***REDACTED***
use_sticky_comment: true
allowed_bots: devin-ai-integration[bot]
claude_args: --max-turns 25
--model claude-opus-4-8
--allowedTools "Read,Glob,Grep,Bash(git diff:*)"
prompt: You are reviewing a PR to check whether any agent instruction files need updating.
In this repo:
- Root shared agent guidance lives in `AGENTS.md`.
- Root `CLAUDE.md` is only a Claude Code adapter that imports `AGENTS.md`.
- Subdirectories may still have scoped `CLAUDE.md` files.
- `.claude/rules/` contains additional Claude Code guidance.
## Your task
1. Run `git diff origin/main...HEAD --name-only` to see which files changed in this PR.
2. For each changed directory, check the applicable instruction files: root `AGENTS.md`, any `CLAUDE.md` in that directory or a parent directory, and relevant `.claude/rules/` files.
3. Determine if any instruction file should be updated based on the changes. Consider:
- New files/directories that aren't covered by existing documentation
- Changed architecture or patterns that contradict current agent guidance
- New dependencies, services, or infrastructure that agents should know about
- Renamed or moved files that are referenced in an instruction file
- Changes to build commands, test patterns, or development workflows
## Response format
If NO updates are needed, respond with exactly:
✅ Agent instruction files look current for this PR.
If updates ARE needed, respond with a short list:
📝 **Agent instruction updates suggested:**
- `AGENTS.md`: [what should be added/changed]
- `path/to/CLAUDE.md`: [what should be added/changed]
- `.claude/rules/file.md`: [what should be added/changed]
Keep suggestions specific and brief. Only flag things that would actually mislead agents in future sessions.
Do NOT suggest updates for trivial changes (bug fixes, small refactors within existing patterns).
Do NOT suggest creating new...
GitHub Actions: 📝 Agent Instructions Audit / 0_audit.txt: feat(run-ops): automatically migrate the dedicated run-ops database
Conclusion: failure
build-batching-rc.2 -> build-batching-rc.2
* [new tag] build-billing-0.0.1 -> build-billing-0.0.1
* [new tag] build-billing-0.0.2 -> build-billing-0.0.2
* [new tag] build-billing-0.0.3 -> build-billing-0.0.3
* [new tag] build-buildinfo-rc.0 -> build-buildinfo-rc.0
* [new tag] build-buildinfo-rc.1 -> build-buildinfo-rc.1
* [new tag] build-checkpoint-failover-rc.1 -> build-checkpoint-failover-rc.1
* [new tag] build-checkpoint-race-condition-1 -> build-checkpoint-race-condition-1
* [new tag] build-checkpoint-race-condition-2 -> build-checkpoint-race-condition-2
* [new tag] build-checkpoint-race-condition-3 -> build-checkpoint-race-condition-3
* [new tag] build-chris-test-blacksmith -> build-chris-test-blacksmith
* [new tag] build-chris-test-blacksmith-2 -> build-chris-test-blacksmith-2
* [new tag] build-cli-build-upgrade-rc.1 -> build-cli-build-upgrade-rc.1
* [new tag] build-clickhouse-reads-rc0 -> build-clickhouse-reads-rc0
* [new tag] build-clickhouse-reads-rc1 -> build-clickhouse-reads-rc1
* [new tag] build-compute.rc0 -> build-compute.rc0
* [new tag] build-compute.rc1 -> build-compute.rc1
* [new tag] build-compute.rc2 -> build-compute.rc2
* [new tag] build-compute.rc3 -> build-compute.rc3
* [new tag] build-compute.rc4 -> build-compute.rc4
* [new tag] build-compute.rc5 -> build-compute.rc5
* [new tag] build-compute.rc6 -> build-compute.rc6
* [new tag] build-corepack-offline-rc.0 -> build-corepack-offline-rc.0
* [new tag] build-current-deployment-rc.0 -> build-current-deployment-rc.0
* [new tag] build-dependabot-q2....
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/replication/src/client.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
internal-packages/replication/src/client.test.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{js,jsx,ts,tsx}: Keep test files beside the files under test and write tests with descriptivedescribeanditblocks.
Avoid mocks or stubs in tests, and use helpers from@internal/testcontainerswhen Redis or Postgres are needed.
Files:
internal-packages/replication/src/client.test.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/replication/src/client.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/replication/src/client.test.ts
🔇 Additional comments (1)
internal-packages/replication/src/client.ts (1)
22-23: LGTM!Also applies to: 707-711
Contributor
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ddab1882-038d-493e-b301-fdaf8ac5a2f7
📒 Files selected for processing (17)
.env.example.server-changes/fix-replication-leader-lock-per-slot.md.server-changes/run-ops-auto-migrate.mdapps/webapp/app/db.server.tsapps/webapp/app/env.server.tsapps/webapp/app/services/runsReplicationInstance.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/splitMode.server.tsapps/webapp/app/v3/runStore.server.tsapps/webapp/test/runsReplicationInstance.test.tsdocker/scripts/entrypoint.shinternal-packages/replication/src/client.test.tsinternal-packages/replication/src/client.tsinternal-packages/run-ops-database/package.jsoninternal-packages/run-ops-database/prisma/schema.prismainternal-packages/run-ops-database/scripts/migrate.mjsinternal-packages/testcontainers/src/utils.ts
💤 Files with no reviewable changes (1)
- .env.example
✅ Files skipped from review due to trivial changes (2)
- .server-changes/run-ops-auto-migrate.md
- .server-changes/fix-replication-leader-lock-per-slot.md
🚧 Files skipped from review as they are similar to previous changes (12)
- internal-packages/run-ops-database/package.json
- internal-packages/testcontainers/src/utils.ts
- apps/webapp/test/runsReplicationInstance.test.ts
- docker/scripts/entrypoint.sh
- apps/webapp/app/v3/runStore.server.ts
- apps/webapp/app/services/runsReplicationInstance.server.ts
- internal-packages/run-ops-database/prisma/schema.prisma
- apps/webapp/app/db.server.ts
- apps/webapp/app/v3/runOpsMigration/splitMode.server.ts
- internal-packages/run-ops-database/scripts/migrate.mjs
- apps/webapp/app/env.server.ts
- apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.ts
📜 Review details
🔇 Additional comments (1)
internal-packages/replication/src/client.ts (1)
22-23: LGTM!Also applies to: 707-711
🛑 Comments failed to post (1)
internal-packages/replication/src/client.test.ts (1)
199-236: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail # Map the test file structure first. ast-grep outline internal-packages/replication/src/client.test.ts --view expanded # Inspect the relevant section around the cited lines. sed -n '160,280p' internal-packages/replication/src/client.test.tsRepository: triggerdotdev/trigger.dev
Length of output: 2954
🏁 Script executed:
#!/bin/bash set -euo pipefail # Locate the replication client implementation and its stop/cleanup logic. fd -a 'client.ts' internal-packages/replication/src rg -n "class LogicalReplicationClient|stop\\(|leaderLockHeartbeatTimer|ackIntervalTimer|redlock|release" internal-packages/replication/src -S # Read the implementation around the cleanup path. ast-grep outline internal-packages/replication/src/client.ts --view expanded sed -n '1,260p' internal-packages/replication/src/client.tsRepository: triggerdotdev/trigger.dev
Length of output: 14520
🏁 Script executed:
#!/bin/bash set -euo pipefail # Find the postgresAndRedisTest helper definition. rg -n "function postgresAndRedisTest|const postgresAndRedisTest|export .*postgresAndRedisTest" . -S # Inspect the helper and any test-level cleanup around this file. fd -a 'postgresAndRedisTest' . rg -n "afterEach\\(|beforeEach\\(|finally|try \\{" internal-packages/replication/src/client.test.ts -SRepository: triggerdotdev/trigger.dev
Length of output: 290
🏁 Script executed:
#!/bin/bash set -euo pipefail sed -n '620,760p' internal-packages/testcontainers/src/index.tsRepository: triggerdotdev/trigger.dev
Length of output: 5616
Wrap the assertions in
try/finallyso both clients are stopped on failure. If anexpectthrows,a.stop()/b.stop()never run, leaving the heartbeat/ack timers and leader lock active until process teardown.
d-cs
force-pushed
the
runops/pr11-auto-migrate-new-db
branch
from
502471c to
875f53f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Base automatically changed from
fix/runs-replication-leader-lock-per-slot
to
main
July 4, 2026 15:02
Adds the ability to migrate the NEW dedicated run-ops database automatically,
matching how every other DB in the system is migrated.
- New `@internal/run-ops-database` migrate runner (scripts/migrate.mjs) exposed as
`db:migrate:deploy` / `db:migrate:status`. Resolves the connection the same way the
webapp does (RUN_OPS_DATABASE_URL, falling back to TASK_RUN_DATABASE_URL; direct
endpoint preferred for migrations) and expands ${VAR} refs like Prisma's dotenv.
- docker/scripts/entrypoint.sh runs the run-ops migration on boot when the DB is
configured, gated by SKIP_RUN_OPS_MIGRATIONS. Single-DB installs are a no-op.
- Unify the NEW-DB connection URL on a single canonical `runOpsNewDatabaseUrl`
(RUN_OPS_DATABASE_URL ?? TASK_RUN_DATABASE_URL) across every consumer (connect path,
split-decision predicates, replication source) so migrations always target the DB
the app connects to.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the separate directUrl / RUN_OPS_DATABASE_DIRECT_URL. It was only consumed by `prisma migrate` (never the app runtime) to bypass a pooler for advisory locks — but the run-ops connection isn't wired to the app yet and the migration only needs one endpoint. Point RUN_OPS_DATABASE_URL at the direct DB endpoint and it's fully covered. A pooled/ direct split can be reintroduced with directUrl if the app ever connects via a pooler. Removes directUrl from the schema, the env.server.ts declaration, the .env.example line, the migrate runner's direct resolution, and the testcontainer helper's dead env var. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The NEW-DB writer had two names (TASK_RUN_DATABASE_URL from the original split + RUN_OPS_DATABASE_URL used by the schema/docker/.env), bridged by a `??` coalesce. Collapse to a single canonical RUN_OPS_* family and delete the aliases (nothing deployed uses them yet): - TASK_RUN_DATABASE_URL -> RUN_OPS_DATABASE_URL (the writer; the ?? and the runOpsNewDatabaseUrl indirection are gone — consumers read env.RUN_OPS_DATABASE_URL directly) - TASK_RUN_LEGACY_DATABASE_URL -> RUN_OPS_LEGACY_DATABASE_URL - TASK_RUN_DATABASE_READ_REPLICA_URL -> RUN_OPS_DATABASE_READ_REPLICA_URL - TASK_RUN_DATABASE_DIRECT_URL -> removed (dead; the schema no longer declares directUrl) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d-cs
force-pushed
the
runops/pr11-auto-migrate-new-db
branch
from
875f53f to
0464ddb
Compare
ericallam
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the ability to automatically migrate the dedicated run-ops database (the NEW DB in the run-ops split), matching how every other database in the system is migrated. Follow-up to the run-ops split activation.
Changes
internal-packages/run-ops-database/scripts/migrate.mjs, exposed asdb:migrate:deploy/db:migrate:status. Connects viaRUN_OPS_DATABASE_URL(the same var the app uses) and expands${VAR}refs like Prisma's dotenv.docker/scripts/entrypoint.shruns the run-ops migration on boot when the DB is configured, gated bySKIP_RUN_OPS_MIGRATIONS. Single-DB installs never set the URL, so it's a clean no-op.RUN_OPS_*family, connect path and migrations resolving the identical URL:RUN_OPS_DATABASE_URL(writer) — replacesTASK_RUN_DATABASE_URLRUN_OPS_LEGACY_DATABASE_URL— replacesTASK_RUN_LEGACY_DATABASE_URLRUN_OPS_DATABASE_READ_REPLICA_URL— replacesTASK_RUN_DATABASE_READ_REPLICA_URLTASK_RUN_*aliases, the??coalesce, therunOpsNewDatabaseUrlindirection, and the migrate-onlydirectUrlare all removed (consumers readenv.RUN_OPS_DATABASE_URLdirectly).directUrlwas dropped because it was only ever used byprisma migrate(never the app runtime) to bypass a pooler for advisory locks — premature here since the run-ops connection isn't wired to the app yet. If a pooler is later introduced for the app, a direct URL can be reintroduced then.Safety
TASK_RUN_*var (the split isn't activated anywhere yet;.env.example, docker-compose, and cloud already useRUN_OPS_*), so there is no config migration.RUN_OPS_DATABASE_URLis unset.db:migrate:deploy/db:migrate:statuscommands.Verification
RUN_OPS_DATABASE_URLset: both migrations applied, noP1012/P1013;${VAR}expansion, idempotent re-run,status, and no-op skip all pass.typecheck --filter webapp18/18; affected split/replication tests 34/34.Scope
This delivers automatic migrations only. Enabling the app to use the new DB (setting
RUN_OPS_DATABASE_URL+RUN_OPS_SPLIT_ENABLEDon the service) is a separate activation step.🤖 Generated with Claude Code