feat(webapp): add region override to the bulk replay action#4022
feat(webapp): add region override to the bulk replay action#4022matt-aitken wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: a8fb134 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
WalkthroughThe pull request adds an optional "Override region" feature to bulk replay actions. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
matt-aitken
force-pushed
the
feature/bulk-replay-region
branch
from
cbfa6fa to
d74adf4
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
matt-aitken
force-pushed
the
feature/bulk-replay-region
branch
from
d74adf4 to
cbfa6fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
matt-aitken
force-pushed
the
feature/bulk-replay-region
branch
from
cbfa6fa to
17990e0
Compare
When replaying runs in bulk from a deployed environment, you can now choose which region the replayed runs run in. The inspector shows an "Override region" dropdown that defaults to "Don't override", which keeps each run in its original region, so replaying a selection that spans multiple regions doesn't silently re-route anything. Pick a region and every matched run is replayed there instead.
ericallam
force-pushed
the
feature/bulk-replay-region
branch
from
17990e0 to
a8fb134
Compare
🧭 Helm Chart Prerelease PublishedVersion: Install: helm upgrade --install trigger \
oci://ghcr.io/triggerdotdev/charts/trigger \
--version "4.5.0-rc.7-pr4022.a8fb134"
|
| const [data, regionsResult] = await Promise.all([ | ||
| presenter.call({ | ||
| organizationId: project.organizationId, | ||
| projectId: project.id, | ||
| environmentId: environment.id, | ||
| request, | ||
| }), | ||
| new RegionsPresenter().call({ | ||
| userId: user.id, | ||
| projectSlug: projectParam, | ||
| isAdmin: user.admin || user.isImpersonating, | ||
| }), | ||
| ]); |
There was a problem hiding this comment.
🟡 RegionsPresenter failure in Promise.all blocks cancel bulk-action flow
The loader now calls RegionsPresenter via Promise.all alongside the existing CreateBulkActionPresenter (bulkaction.tsx:87-99). RegionsPresenter.call() can throw (e.g., RegionsPresenter.server.ts:65-66 when defaultWorkerInstanceGroupId feature flag is not set). Because Promise.all rejects on the first failure, a RegionsPresenter error will prevent the entire bulk-action inspector from loading — including the cancel flow, which has no dependency on regions. Before this PR the loader never depended on regions, so this is a regression: self-hosted instances or environments without the feature flag configured will lose access to both cancel and replay bulk actions.
Prompt for agents
In the loader, the RegionsPresenter.call() is invoked inside Promise.all alongside the existing CreateBulkActionPresenter.call(). If RegionsPresenter throws (e.g. missing defaultWorkerInstanceGroupId feature flag), the entire loader fails, breaking both cancel and replay bulk action flows.
The fix should catch the RegionsPresenter error and fall back to an empty regions array so the bulk action inspector degrades gracefully (region selector hidden, cancel flow unaffected).
One approach: wrap the RegionsPresenter call with tryCatch (already imported in this file from @trigger.dev/core) or a try/catch, and default to { regions: [] } on failure. For example:
const [regionsError, regionsResult] = await tryCatch(new RegionsPresenter().call({...}));
const regions = regionsError ? [] : regionsResult.regions;
Then use `regions` directly in the typedjson return instead of regionsResult.regions.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
When replaying runs in bulk from a deployed environment, you can now choose which region the replayed runs run in. The bulk action inspector shows an "Override region" dropdown that defaults to "Don't override", which keeps each run in its original region, so replaying a selection that spans multiple regions doesn't silently re-route anything. Pick a region and every matched run is replayed there instead.
The dropdown only appears for the replay action in a deployed environment with more than one region available; cancel actions and development environments don't show it.
Design
The selected region is carried through the bulk action as a dedicated
replayRegionparam, kept separate from the run-list selection filters so it can't be confused with a region selection filter. When the action runs, each replay passes it through to the existing region override on the replay service, which already falls back to each run's original region when no override is set. "Don't override" is a sentinel value that the action normalizes away so the service only ever sees a real region or nothing.