Skip to content

[codex] Fix ordinal-only export parsing#221

Merged
dguido merged 1 commit into
masterfrom
fix-207-ordinal-only-exports
Jun 22, 2026
Merged

[codex] Fix ordinal-only export parsing#221
dguido merged 1 commit into
masterfrom
fix-207-ordinal-only-exports

Conversation

@dguido

@dguido dguido commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • parse export directories when VirtualAddress is present even if Size is zero
  • include ordinal-only exports while skipping empty EAT slots
  • preserve named export ordering and avoid partial export insertion on malformed zero-size directories
  • add synthetic export fixture coverage plus a real Corkami dllemptyexp.dll regression test

Validation

  • ctest --test-dir passed in Debug/Release and shared/static builds
  • Debug shared/static ASan+UBSan builds passed full CTest (15/15 each)
  • direct IterExpFull differential over Corkami: 231 scanned, 184 comparable, 24 exports matched, 0 mismatches
  • sanitizer dump-pe smokes passed for tests/assets/example.exe and Corkami dllemptyexp.dll
  • pepy wheel and sdist build/install/smoke passed
  • git diff --check
  • full tracked-source clang-format --dry-run -Werror -style=file

@dguido dguido merged commit a98bacf into master Jun 22, 2026
27 of 39 checks passed
@dguido dguido deleted the fix-207-ordinal-only-exports branch June 22, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant