Skip to content

DOC-2898: Documentation enhancements: for https://www.tiny.cloud/docs/tinymce/latest/custom-toggle-toolbar-button/#4071

Open
jeslynbo wants to merge 8 commits intotinymce/8from
hotfix/8/testingPR
Open

DOC-2898: Documentation enhancements: for https://www.tiny.cloud/docs/tinymce/latest/custom-toggle-toolbar-button/#4071
jeslynbo wants to merge 8 commits intotinymce/8from
hotfix/8/testingPR

Conversation

@jeslynbo
Copy link
Copy Markdown

@jeslynbo jeslynbo commented Apr 16, 2026

Ticket: DOC-2898

Site: Staging branch

Changes:

  • Simplified onSetup event handling and teardown logic
  • Replacing plain inline code with a cross-referenced API link
  • Edited comments for onSetup demo
  • Ensure {product name} is being used correctly

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • modules/ROOT/nav.adoc has been updated (if applicable).
  • Included a release note entry for any New product features.
  • If this is a minor release, updated productminorversion in antora.yml and added new supported versions entry in modules/ROOT/partials/misc/supported-versions.adoc.

Review:

  • Documentation Team Lead has reviewed

@jeslynbo jeslynbo requested review from a team, kemister85 and soritaheng as code owners April 16, 2026 01:37
@jeslynbo jeslynbo marked this pull request as draft April 16, 2026 01:40
…criptions for component creation and destruction callbacks.
@jeslynbo jeslynbo marked this pull request as ready for review April 20, 2026 09:42
Copy link
Copy Markdown
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements overall — the restructured explanation, clearer option/API descriptions, and the formatChanged documentation with unbind() are all valuable. A few issues to fix before merge (suggestions provided inline so you can commit them directly).

Comment thread modules/ROOT/pages/custom-toggle-toolbar-button.adoc Outdated
Comment thread modules/ROOT/pages/custom-toggle-toolbar-button.adoc Outdated
Comment thread modules/ROOT/pages/custom-toggle-toolbar-button.adoc Outdated
Comment thread modules/ROOT/pages/custom-toggle-toolbar-button.adoc Outdated
Comment on lines +57 to +59
The `+formatChanged+` method accepts the following parameters:

The `+vars+` argument controls which variables are used to match the content when determining whether to run the callback. This argument is only used when `+similar+` is `+false+`.
The `+formatChanged+` method accepts the following parameters:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated paragraph — remove the first occurrence.

Suggested change
The `+formatChanged+` method accepts the following parameters:
The `+vars+` argument controls which variables are used to match the content when determining whether to run the callback. This argument is only used when `+similar+` is `+false+`.
The `+formatChanged+` method accepts the following parameters:
The `+formatChanged+` method accepts the following parameters:

Comment thread modules/ROOT/pages/custom-toggle-toolbar-button.adoc Outdated
Comment thread modules/ROOT/partials/misc/onSetup.adoc Outdated
jeslynbo and others added 6 commits May 11, 2026 11:29
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants