fix: SW-2076 harmonize hover states — add missing button & select hovers#149
Open
boramyi-ts wants to merge 1 commit into
Open
fix: SW-2076 harmonize hover states — add missing button & select hovers#149boramyi-ts wants to merge 1 commit into
boramyi-ts wants to merge 1 commit into
Conversation
- Default (primary) button: replace anchor-only [a]:hover:bg-primary/80
with hover:bg-primary/85, so real <button>s (not just anchors) get a
hover — this was the main gap ("some buttons have hover, some don't").
- Secondary button: hover:bg-secondary/75 (light) + dark:hover:bg-secondary/85
for a more visible hover on the pale light-mode secondary.
- Select trigger: add hover:bg-accent for light mode (previously only
dark:hover:bg-input/50 — no light hover).
The outline/ghost/toggle muted->accent unification is owned by SW-2071
(#140) and intentionally not duplicated here.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
boramyi-ts
temporarily deployed
to
artifactory-prod
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
54321jenn-ts
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SW-2076 — "harmonize hover states for buttons; some have hover and some don't." Adds the missing hover states and tunes the secondary hover.
Changes
[a]:hover:bg-primary/80→hover:bg-primary/85. The hover was anchor-only, so a real<button variant="default">(the most common button) had no hover at all. Now both buttons and anchors respond. (Also covers the default icon button.)hover:bg-secondary/80→hover:bg-secondary/75(light) +dark:hover:bg-secondary/85, for a more visible hover on the pale light-mode secondary.hover:bg-accentfor light mode (previously onlydark:hover:bg-input/50— no light hover).Scope note
The
outline/ghost/toggleneutral-hovermuted → accentunification (also shown in the prototype) is owned by SW-2071 (#140) and intentionally not duplicated here to avoid conflicts.Before / after
Interactive prototype (mouse over each element; columns show the before vs after hover spec + tag):
📄 sw-2076-hover-before-after.html · download raw
yarn lint+yarn typecheckpass. Verified in Storybook: default button now carrieshover:bg-primary/85, secondaryhover:bg-secondary/75 dark:hover:bg-secondary/85, selecthover:bg-accent.🤖 Generated with Claude Code