Don't need to set GLIBCXX_USE_CXX11_ABI variable when using Bazel#1024
Open
mhucka wants to merge 2 commits intotensorflow:masterfrom
Open
Don't need to set GLIBCXX_USE_CXX11_ABI variable when using Bazel#1024mhucka wants to merge 2 commits intotensorflow:masterfrom
GLIBCXX_USE_CXX11_ABI variable when using Bazel#1024mhucka wants to merge 2 commits intotensorflow:masterfrom
Conversation
This environment variable is set in `.bazelrc`, so it is no longer necessary to add `-D_GLIBCXX_USE_CXX11_ABI=1` all over the place when running Bazel.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the -D_GLIBCXX_USE_CXX11_ABI=1 flag from various Bazel commands across the documentation and shell scripts. A critical syntax error was identified in scripts/benchmark_all.sh where an invalid bash substitution was used to define a command shortcut, which would cause the script to fail during execution.
mhucka
changed the title
GLIBCXX_USE_CXX11_ABIGLIBCXX_USE_CXX11_ABI variable when using Bazel
mhucka
added
the
area/devops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This environment variable is set in
.bazelrc, so it is no longer necessary to add-D_GLIBCXX_USE_CXX11_ABI=1all over the place when running Bazel.