refactor(e2e): remove reliance on Repository.Status in wait functions

[zakisk]

📝 Description of the Change

The Repository CR's Status field is deprecated and will be removed. This refactors E2E test wait helpers to use PipelineRun objects directly instead of polling Repository.Status:

• Remove UntilRepositoryUpdated and UntilRepositoryHasStatusReason
• Remove FailOnRepoCondition from wait.Opts
• Modify UntilPipelineRunCreated and UntilPipelineRunHasReason to return []PipelineRun so callers can inspect annotations and conditions
• Add UntilPipelineRunsFinished for mixed-outcome tests (1 pass + 1 fail)
• Rewrite Succeeded() helper to validate PipelineRun annotations instead of repo.Status fields
• Migrate all ~40 call sites across 20 test files

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

• Unit tests
• Integration tests
• End-to-end tests
• Manual testing
• Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

• I have not used any AI assistance for this PR.
• I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

• 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
• ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
• ♽ I have run make test and make lint locally to check for and fix any
  issues. For an efficient workflow, I have considered installing
  pre-commit and running pre-commit install to
  automate these checks.
• 📖 I have added or updated documentation for any user-facing changes.
• 🧪 I have added sufficient unit tests for my code changes.
• 🎁 I have added end-to-end tests where feasible. See README for more details.
• 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
• If adding a provider feature, I have filled in the following and updated the provider documentation:
  • GitHub App
  • GitHub Webhook
  • Gitea/Forgejo
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center

[gemini-code-assist]

Code Review

This pull request refactors the end-to-end tests to monitor and assert on Tekton PipelineRuns directly rather than waiting for Repository status updates. The feedback highlights a recurring issue across multiple test files where the code directly accesses the Conditions slice by index (e.g., Conditions[0]) on a PipelineRun status. Since the order of conditions is not guaranteed, it is highly recommended to use GetCondition(apis.ConditionSucceeded) to safely and reliably retrieve the 'Succeeded' condition.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.01%. Comparing base (27ac5d7) to head (9764163).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files         211      211           
  Lines       17228    17228           
=======================================
  Hits        10511    10511           
  Misses       5917     5917           
  Partials      800      800           

Flag	Coverage Δ
unit-tests	61.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chmouel]

[AI Reviews]

The ordering fixes and restoration of the Gitea on-comment golden coverage are the correctness issues that need attention here. I have left the condition-access findings out because Gemini already opened threads for those lines.

One semantic note on TestGitlabMergeRequest: restoring SHA: mr.SHA directly would make the new helper wait for five PipelineRuns with that SHA, unlike the old helper which counted all statuses and then selected a matching SHA. The current unfiltered wait avoids that timeout, but if explicit SHA validation remains part of the test contract it should be preserved separately from the total-count wait.

Please add ordering unit coverage with deliberately reversed creation timestamps. The relevant local checks are go test ./test/pkg/wait and go test -run '^$' -tags=e2e ./test; go build ./test/... does not compile the changed _test.go files.

[zakisk]

there are many failures and they will be on next pushes as well because our E2E tests were heavily reliant on repo.Status field, working to resolve them locally instead of running here because they're time consuming...

[chmouel]

there are many failures and they will be on next pushes as well because our E2E tests were heavily reliant on repo.Status field, working to resolve them locally instead of running here because they're time consuming...

yeah not a trivial task you took! but this would be great and more robust when we get there

[theakshaypant]

Converting this to draft in the meanwhile.

[zakisk]

TestGithubGHEMaxKeepRuns was failing but now it's passing so it's flake. I am gonna run E2E on this again and again to see frequency of flakiness...

[zakisk]

TestGithubGHEMaxKeepRuns was failing but now it's passing so it's flake. I am gonna run E2E on this again and again to see frequency of flakiness...

actually I found the reason for flakiness...

[zakisk]

bitbucket cloud API issue two time... 😕

{"level":"info","ts":1782822463.6097746,"caller":"bitbucketcloud/bitbucket.go:223","msg":"bitbucket-cloud: initialized client with provided token for user=cboudjna"}
    crd.go:27: assertion failed: error is not nil: 401 Unauthorized

[theakshaypant]

Love that the CI is all green, I did rerun the concurrency tests.
Adding some comments from an AI-assisted review.