This repository was archived by the owner on Jul 12, 2026. It is now read-only.
Match method-name docblock descriptions with articles and punctuation#89
Closed
TomasVotruba wants to merge 3 commits into
Closed
Match method-name docblock descriptions with articles and punctuation#89TomasVotruba wants to merge 3 commits into
TomasVotruba wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveMethodNameDuplicateDescriptionFixermatched a description line only when its space-stripped content was exactly the method name (e.g.* Set name→setName). Human-written phrasing with articles or trailing punctuation slipped through.This normalizes the line before comparison: drops articles (
a/an/the) and strips non-alphanumeric chars (whitespace + trailing.,!,:).final class ApiIntegration { /** - * Get the API helper. - * * @return object */ public function getApiHelper() { } }Existing matches (
Set name,Get now) still removed. New fixturewith_articles.php.inccovers the article case.