Skip to content

Pr zbus 1771 #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mulkieran wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Pr zbus 1771 #1284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13f8dba
Revert "Only match org.freedesktop.zbus.Error for property setting"
mulkieran Jun 10, 2026
c6d5a53
Remove match for org.freedesktop.zbus.Error
mulkieran Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/stratis_cli/_error_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,17 +264,6 @@ def _interpret_errors_2(errors: List[BaseException]) -> Optional[str]: # noqa:
dbus_message = next_error.get_dbus_message()
context = error.context

if dbus_name == "org.freedesktop.zbus.Error" and isinstance(
context, DPClientSetPropertyContext
):
return (
f"stratisd failed to perform the operation that you "
f"requested, because it could not set the D-Bus "
f'property "{context.property_name}" belonging to '
f'interface "{error.interface_name}" to "{context.value}". '
f"It returned the following error: {dbus_message}."
)

# We do not test this error, as the only known way to cause it is
# manipulation of selinux configuration, which is too laborious to
# bother with at this time.
Expand Down Expand Up @@ -312,6 +301,15 @@ def _interpret_errors_2(errors: List[BaseException]) -> Optional[str]: # noqa:
f"service sent the following message: {dbus_message}."
)

if isinstance(context, DPClientSetPropertyContext): # pragma: no cover
return (
f"stratisd failed to perform the operation that you "
f"requested, because it could not set the D-Bus "
f'property "{context.property_name}" belonging to '
f'interface "{error.interface_name}" to "{context.value}". '
f"It returned the following error: {dbus_message}."
)

if isinstance(context, DPClientGetPropertyContext): # pragma: no cover
return (
f"stratisd failed to perform the operation that you "
Expand Down
Loading