Fix NAND archive path resolution and OLED temp space checks#11
Open
denchik28 wants to merge 2 commits intosthetix:mainfrom
Open
Fix NAND archive path resolution and OLED temp space checks#11denchik28 wants to merge 2 commits intosthetix:mainfrom
denchik28 wants to merge 2 commits intosthetix:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues in
nandfixpro.py:NAND archive resolution
In several flows, archive paths were hardcoded to
script_dir/lib/NAND, which could fail depending on runtime context.The code now resolves archives consistently via
partitions_folderfrom Settings, with a stable app-directory fallback.Temp disk space checks for OLED / 64GB NAND
Space checks were previously static and could underestimate required free space for OLED-sized NAND.
The required free temp space is now dynamic:
32GB NANDclass -> 64GB required64GB NANDclass (OLED) -> 128GB requiredWhat changed
_get_app_base_dir()_get_partitions_folder()_estimate_nand_size_gb()_required_temp_space_gb()lib/NANDpath usage in:Validation
python3 -m py_compile nandfixpro.pypasses.