Skip to content

fix(@stdlib/_tools/repl-txt/rules/doctest): guard against null alias in replaceAliases #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Planeshifter wants to merge 1 commit into from
+1 −1
Closed

fix(@stdlib/_tools/repl-txt/rules/doctest): guard against null alias in replaceAliases #13472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
var b;
var i;

// FIXME: clean-up this logic

Check warning on line 95 in lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'fixme' comment: 'FIXME: clean-up this logic'

if ( context.meta.filepath ) {
expected = [];
Expand All @@ -105,7 +105,7 @@
};
pkgName = pkg2alias( pkg ) || 'ALIAS';

// TODO: use @stdlib/utils/deep-set once refactored!

Check warning on line 108 in lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: use @stdlib/utils/deep-set once...'
pkgName = pkgName.split( '.' );
N = pkgName.length;
o = scope;
Expand All @@ -120,7 +120,7 @@
o[ key ] = require( pkg ); // eslint-disable-line stdlib/no-dynamic-require
}
}
// TODO: process external aliases *BEFORE* creating the context (and also, what is going on here, given that the return value is ignored?)

Check warning on line 123 in lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: process external aliases *BEFORE*...'
vm.createContext( scope );

examples = section.examples;
Expand Down Expand Up @@ -171,11 +171,11 @@
var o;
var i;

alias = pkg2alias( pkg );
alias = pkg2alias( pkg ) || 'ALIAS';
alias = alias.split( '.' );
len = alias.length;

// TODO: use @stdlib/utils/deep-set once refactored!

Check warning on line 178 in lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: use @stdlib/utils/deep-set once...'
o = scope;
for ( i = 0; i < len; i++ ) {
key = alias[ i ];
Expand Down