[5.x] fix save crash after deleting a Bard set containing a hidden field#15010
Closed
werner-freytag wants to merge 1 commit into
Closed
[5.x] fix save crash after deleting a Bard set containing a hidden field#15010werner-freytag wants to merge 1 commit into
werner-freytag wants to merge 1 commit into
Conversation
Member
|
Thanks for the pull request! Although, as per our support policy, v5 is no longer receiving bug fixes so I'm going to close this PR. If you need this fix on your site, consider using a composer patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15007 for 5.x. See #15008 for same issue in 6.x branch.
Deleting a Bard set leaves a
nullnode in the in-memory value, which makesforgetValue()→data_delete()throw aTypeErroron save. See the issue for the full root-cause analysis and reproduction.Fix (
resources/js/components/publish/Values.js)missingValue(): treat anullintermediate as missing, soforgetValue()correctly bails out.data_delete(): guard against non-object intermediates (and the finaldelete) as a safety net for all callers.Test added in
resources/js/tests/PublishValues.test.js.